New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in newsfeed module using `removeStartTags` on a description #1478

Closed
michael5r opened this Issue Dec 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@michael5r
Copy link
Contributor

michael5r commented Dec 7, 2018

Platform: Raspberry Pi 3, Mac
Node Version: 8.9.0
MagicMirror Version: 2.5

Description:
There's a bug in the default newsfeed module in newsfeed.js when removeStartTags is used on the description - it's copying the sliced result back into the title, instead of the description.

Line 141

this.newsItems[this.activeItem].title = ... [snip]

should be:

this.newsItems[this.activeItem].description = ... [snip]
@michael5r

This comment has been minimized.

Copy link
Contributor

michael5r commented Dec 10, 2018

I'd be happy to open a PR for this tiny change, but I was unable to find code contribution guidelines.

@MichMich

This comment has been minimized.

Copy link
Owner

MichMich commented Dec 10, 2018

PR to the develop branch is more than welcome. Thanks! Dont forget to add the changelog.

@MichMich

This comment has been minimized.

Copy link
Owner

MichMich commented Dec 19, 2018

Merged!

@MichMich MichMich closed this Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment