Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new weather module #1499

Closed
apm1007 opened this Issue Jan 2, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@apm1007
Copy link

apm1007 commented Jan 2, 2019

i found three problems with the new weather module
decimal signal isnt working.
grafik
grafik
layout of forecast ist far to big. dunno why there are empty lines compared to the old forecast
grafik
hour forecast isnt possible.
Pretty Good idea for taking indoor temp and humidity to the weather module! but would be great to get the symbols vertical for better screen use.
grafik
Thank you!

@MichMich

This comment has been minimized.

Copy link
Owner

MichMich commented Jan 2, 2019

@apm1007 Thanks for your feedback!

@fewieden do you want me to tag you in these issue reports?

@fewieden

This comment has been minimized.

Copy link
Contributor

fewieden commented Jan 3, 2019

@MichMich sure you can tag me it will not hurt, but I'm back at work now, so I can't promise anything.

  1. Decimal symbol was not implemented, but still documented in the readme. I added it and it will be in the next pr.

  2. I'm not sure yet why the forecast table has this spacing. Will have a look when I find time to debug this.

  3. The indoor values are horizontal like in the currentweather module. I made them now smaller and vertical. Also added a class to it so people can style it individually. Will be in next pr.

@fewieden

This comment has been minimized.

Copy link
Contributor

fewieden commented Jan 5, 2019

All 3 points are handled in #1510

@MichMich

This comment has been minimized.

Copy link
Owner

MichMich commented Jan 8, 2019

Merged.

@MichMich MichMich closed this Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.