Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New weather module current.njk JS error on develop branch #1538

Closed
vincep5 opened this Issue Jan 16, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@vincep5
Copy link
Contributor

vincep5 commented Jan 16, 2019

Issue with current.njk on the develop branch. When I add the "current" module, I get a JS error: TypeError: value.replace is not a function. It's because of

this.nunjucksEnvironment().addFilter("decimalSymbol", function(value) { return value.replace(/\./g, this.config.decimalSymbol); }.bind(this));
value.replace throws the error. If I put it as value.toString().replace, it works

Also the "Loading . . ." string is escaped improperly in the current.njk and forecast.njk
it shows up as "Loading &hellip"

@MichMich

This comment has been minimized.

Copy link
Owner

MichMich commented Jan 17, 2019

Could you please send a PR to fix this? Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.