Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags at the beginning and/or end of newsfeed items #416

Merged
merged 6 commits into from Aug 27, 2016

Conversation

yo-less
Copy link
Contributor

@yo-less yo-less commented Aug 26, 2016

Many feed descriptions end with with a link tag to the actual article online (see http://www.deutschlandfunk.de/die-nachrichten.353.de.rss, for example - tag: " mehr."). The mirror news description looks strange with this tag in the end.

Other newsfeeds feature tags at the beginning of an item (see http://www.francetvinfo.fr/titres.rss - tags like "VIDEO" or "CARTE" are placed at the beginning of some titles), which also make very little sense within the setup of this project.

I have added an option to remove the tags from the beginning or end of an item's description and/or title and updated the readme.md accordingly.

Many feed descriptions end with with a link tag to the actual article
online (see http://www.deutschlandfunk.de/die-nachrichten.353.de.rss,
for example). The mirror news description looks strange with this tag in
the end.

I have added an option to remove the tag from the description and
updated the readme.md accordingly.
User-specified feed tags in description and title can be removed
Updated README.md for legibility
Added options: both, description, title
@jtyle6
Copy link

jtyle6 commented Aug 27, 2016

Wong Merge. please push it to develop tree

@yo-less yo-less changed the base branch from master to develop August 27, 2016 02:28
@MichMich MichMich merged commit 2ae0c98 into MagicMirrorOrg:develop Aug 27, 2016
@MichMich
Copy link
Collaborator

Thanks for your contribution! I posted a test request: https://forum.magicmirror.builders/post/4012 if necessary, please post additional test info there. Thanks!

@jtyle6
Copy link

jtyle6 commented Aug 28, 2016

It work's, I can't read German (Deutsch).
2016-08-28-200549_1280x800_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants