Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCManFM has broken icons #1558

Closed
gammaleak opened this issue Feb 26, 2018 · 15 comments

Comments

@gammaleak
Copy link

commented Feb 26, 2018

Creating a bug report/issue:

Required Information:

  • DietPi Version | cat /DietPi/dietpi/.version? v6.2
  • SBC Device (EG: RPi 3)? RPi3
  • Power supply used (EG: 5v 1A RAVpower)? 5V 2.5A
  • SD card used (EG: Sandisk ultra)? LoveRPi branded
  • Distro (EG: Jessie) | uname -a? Stretch

Additional Information (if applicable):

  • Software title? PCManFM
  • Can this issue be replicated on a fresh installation of DietPi? Yes

Expected behaviour:

If you install LXDE, the basic applications that come with it should all have fully functioning icons.

Actual behaviour:

PCManFM has broken icons for the "View" toggles (i.e., "Large Icons," "Small Icons," "Detailed List," etc.)

Steps to reproduce:

  1. Install DietPi with LXDE
  2. Launch LXDE
  3. Observe broken icons in toolbar

Did you submit a dietpi-bugreport?

I didn't submit one.

Extra details:

I tried adding a new icon set (Oxygen) from the repository, but that didn't fix the issue. Seems like maybe PCManFM is expecting to find those icons somewhere specific and they aren't there?

@MichaIng

This comment has been minimized.

Copy link
Owner

commented Feb 26, 2018

@gammaleak
Thanks for your report, I will try to replicate on VM.

@MichaIng

This comment has been minimized.

Copy link
Owner

commented Feb 26, 2018

@gammaleak
I couldn't replicate on Stretch VM. LXDE and PCManFM working and icons looking as they should.

Do you see any error messages within journalctl? Don't know where PCManFM/Openbox would drop their error messages actually, didn't use a desktop for a long time 😅.

In case someone with testing RPi has to try replicate.

@MichaIng MichaIng added the RPi label Feb 26, 2018
@Fourdee Fourdee added this to the v6.3 milestone Feb 27, 2018
@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2018

RPi 3 Stretch LXDE fresh install:

  • Other devices are fine, RPi issue only.
  • 🈴 Confirmed
    image
@Fourdee Fourdee added the Bug 🐞 label Feb 27, 2018
@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2018

** (pcmanfm:9863): WARNING **: The directory '/root/Templates' doesn't exist, ignoring it

(pcmanfm:9863): Gtk-CRITICAL **: IA__gtk_menu_shell_insert: assertion 'GTK_IS_MENU_SHELL (menu_shell)' failed
root@DietPi:~# dpkg -l | grep icon
ii  adwaita-icon-theme             3.22.0-1+deb9u1              all          default icon theme of GNOME
ii  gtk-update-icon-cache          3.22.11-1+rpi3               armhf        icon theme caching utility
ii  hicolor-icon-theme             0.15-1                       all          default fallback theme for FreeDesktop.org icon themes
ii  libtext-iconv-perl             1.7-5+b8                     armhf        converts between character sets in Perl
ii  lxde-icon-theme                0.5.1-2                      all          LXDE standard icon theme
  • Favorites tab missing aswell.
  • 🈴 "Customize look and appearance" hangs LXDE over VNC, terminate dbus-launch resolves.
  • 🈯️ Adwaita/PiX resolves broken LXDE toolbar icons. 🈺 Reset after reboot/service restart
root@DietPi:~# cat .gtkrc-2.0
# DO NOT EDIT! This file will be overwritten by LXAppearance.
# Any customization should be done in ~/.gtkrc-2.0.mine instead.

include "/root/.gtkrc-2.0.mine"
gtk-theme-name="Clearlooks"
gtk-icon-theme-name="Adwaita"
gtk-font-name="Sans 10"
gtk-cursor-theme-size=18
gtk-toolbar-style=GTK_TOOLBAR_BOTH_HORIZ
gtk-toolbar-icon-size=GTK_ICON_SIZE_LARGE_TOOLBAR
gtk-button-images=1
gtk-menu-images=1
gtk-enable-event-sounds=1
gtk-enable-input-feedback-sounds=1
gtk-xft-antialias=1
gtk-xft-hinting=1
gtk-xft-hintstyle="hintslight"
gtk-xft-rgba="rgb"
cat << _EOF_ > ~/.gtkrc-2.0.mine
gtk-theme-name="Clearlooks"
gtk-icon-theme-name="Adwaita"
gtk-font-name="Sans 10"
gtk-cursor-theme-size=18
gtk-toolbar-style=GTK_TOOLBAR_BOTH_HORIZ
gtk-toolbar-icon-size=GTK_ICON_SIZE_LARGE_TOOLBAR
gtk-button-images=1
gtk-menu-images=1
gtk-enable-event-sounds=1
gtk-enable-input-feedback-sounds=1
gtk-xft-antialias=1
gtk-xft-hinting=1
gtk-xft-hintstyle="hintslight"
gtk-xft-rgba="rgb"
_EOF_
@Fourdee Fourdee modified the milestones: v6.3, v6.4, v6.5 Mar 7, 2018
@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2018

Notes:

  • As far as I can tell, the only reason this may be occurring from our side, is:
    -- due to removal of dbus in PREP. However, it is installed via APT during LXDE install. Is it possible removing Dbus initially is the cause?
    I'll need to confirm/exclude this by doing a PREP without removal of DBUS and retest.
@Fourdee Fourdee modified the milestones: v6.5, v6.6, v6.7 Mar 28, 2018
@Fourdee Fourdee modified the milestones: v6.7, v6.8 Apr 15, 2018
@Fourdee Fourdee modified the milestones: v6.8, v6.9 May 13, 2018
@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

Tests:

  • Debian pcmanfm 🈯️
wget http://ftp.us.debian.org/debian/pool/main/p/pcmanfm/pcmanfm_1.2.5-3_armhf.deb
dpkg -i *.deb

RPi version of pcmanfm is the issue, most likely customized towards the RPi desktop, either way, we'll pull in the Debian version to resolve.

Fourdee pushed a commit that referenced this issue May 18, 2018
+ +DietPi-Software | LXDE: Resolved missing icons with 'pcmanfm' under RPi devices: #1558 (comment)
@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

lxappearance still an issue, hangs on open with spawned dbus-launch process:
Terminate dbus-launch and it then runs.

root@DietPi:~# dpkg -l | grep lx | grep rpi
ii  libgl1-mesa-glx:armhf          13.0.6-1+rpi2                armhf        free implementation of the OpenGL API -- GLX runtime
ii  lxde                           9+rpi1                       all          Metapackage for LXDE
ii  lxde-core                      9+rpi1                       all          Metapackage for the LXDE core
ii  lxinput                        0.3.5-1+rpi4                 armhf        LXDE keyboard and mouse configuration
ii  lxpanel                        0.9.3-1+rpi6                 armhf        LXDE panel
ii  lxpanel-data                   0.9.3-1+rpi6                 all          LXDE panel (data files)
ii  lxterminal                     0.3.0-2+rpi1                 armhf        LXDE terminal emulator

root@DietPi:~# dpkg -l | grep openbox | grep rpi
ii  libobrender32v5                3.6.1-4+rpi6                 armhf        rendering library for openbox themes
ii  libobt2v5                      3.6.1-4+rpi6                 armhf        parsing library for openbox
ii  openbox                        3.6.1-4+rpi6                 armhf        standards-compliant, fast, light-weight and extensible window manager

@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2018

Completed, new ticket for the other issues with lxappearance:
#1791 (comment)

@Fourdee Fourdee closed this May 21, 2018
@Fourdee Fourdee referenced this issue Jun 7, 2018
Fourdee added a commit that referenced this issue Jun 7, 2018
**v6.9**
(07/06/18)

**Changes / Improvements / Optimizations:**

General | During first run of DietPi (and during this patch), you will now be given the option to change the global password for 'root' + 'dietpi' accounts, and all future software to be installed that requires a password: #1782

General | Increased verbosity and logging of DietPi boot scripts to assist with debugging: #1772

General | G_ERROR_HANDLER: Retry mechanic added, allows you to re-run and retry the last command when an error occurs. Also included option to send DietPi a bug report when an issue occurs.

General | NTP removed from DietPi-Config time sync options and DietPi core packages. All time sync modes are now offered via systemd-timesyncd, which is part of every Debian based core system: #1628

General | DietPi-Set_Core_Environment was removed. DietPi service and system config files are now updates automatically via new update system, other environment setup steps are moved into DietPi-PREP: #1749

DietPi-BugReport | Has been revised and improved to remove end user security concerns.

DietPi-Drive_Manager | Swapfile: Added ability to move the swapfile and set size. This replaces the previous option in DietPi-Config.

DietPi-Process_Tool | NoMachine + Webmin: Processes can now be controlled.

DietPi-Services | Webmin: Added and now controlled.

DietPi-Software | Fail2Ban: Install now uses the systemD backend. No longer requires Rsyslog pre-req. For new installations only.

DietPi-Software | Search: Feature now available. Find the software you require for install, faster! https://twitter.com/DietPi_/status/1000858660682305536

DietPi-Software | InfluxDB and Grafana now available for installation. Many thanks to @marcobrianza for the install code and documentation guides: #1784

DietPi-Software | LXDE: Resolved missing icons with 'pcmanfm' under RPi devices: #1558 (comment)

DietPi-Software | Webmin: Resolved failed installation due to missing package pre-reqs. Upgraded to use a systemD service: #1741

DietPi-Software | Removed npm root access error during installs: #1340 (comment)

DietPi-Software | OpenJDK/JRE now installs Java version 8 across all DietPi system. This is for stability across all programs that require it: #1340 (comment)

DietPi-Software | Updated several non-APT software titles for fresh installs and reinstalls: #1774

DietPi-Software | Transmission: General clean up of install config file. G_CONFIG_INJECT is now used to replace/add our optimized entries. Also cleaned up the service, now runs as forking: #1754

DietPi-Software | sabnzbd: Updated to latest version 2.3.4 (for new installations only): #1340

DietPi-Software | CAVA: Updated to latest version 0.6.1. Enabled for x86_64: #1340

DietPi-Software | OctoPrint: libjpeg-dev now installed by default, this is required for additional plugin installations (eg: Astroprintcloud Plugin): #1800

DietPi-Software | Xserver: DPMS and all known screen blanking/saving is now disabled by default. To re-enable this feature, remove the following file '/etc/X11/xorg.conf.d/99-dietpi-dpms_off.conf': #1823

DietPi-Survey | Has been revised and improved to remove end user security concerns.

DietPi-Update | Implemented an automated update system for DietPi files, placed outside of /DietPi, e.g. system configurations and service files. This allows significant reduction of script code and assures consistency across all systems: #1802

**Bug Fixes:**

General | Login and globals moved to /etc/bashrc.d/*, due to issues with remote shell and desktop terms under /etc/profile.d/99-dietpi-login.sh: #1777 (comment)

General | Completely removed root permission requirements from login scirpts and banner. Also users without sudo permissions will see the login banner and will be able to use dietpi-* and G_* functions: #1790

General | Sparky SBC + USB-DAC unmute fix (v2), now sets volume to max: #1779

General | UID bit reapplied for Sudo. Reported not applied on current XU4 image: #794 (comment)

DietPi-Config | WiFi HotSpot: Resolved inability to toggle state (enable/disable) and change channel: #1810 (comment)

DietPi-Drive_Manager | Format: Resolved an issue where formatting any drive, would reset the swapfile back to auto size and default location: https://dietpi.com/phpbb/viewtopic.php?f=11&t=3851&p=12864#p12864

DietPi-set_dphys-swapfile | Resolved issues with fallocate on vfat partitions which caused a failure.

DietPi-Software | SickRage: SystemD service updated to prevent timeouts, allowing the process to fully init. Experienced by some users installs: #1762

DietPi-Software | AirSonic: Resolved issues with incorrect memory limit being set during installation: #1764

DietPi-Software | AirSonic/SubSonic: Resolved 503 error when accessing web interface: #1764

DietPi-Software | CloudPrint: Resolved an issue where the CUPS web interface would fail to connect: #1797

DietPi-Software | VNC + LXDE: Resolved error message 'no session for PID x'.:
@puccaso

This comment has been minimized.

Copy link

commented Nov 2, 2018

hey guys - you know, im having the same issue.
i've documented the issue on raspberry pi forums, https://www.raspberrypi.org/forums/viewtopic.php?f=66&t=225936&p=1387128#p1387128

the PIX icon theme works, but nothing else.

@puccaso

This comment has been minimized.

Copy link

commented Nov 2, 2018

image
image
image
Here is my current output.
im on the most recent raspbian - how might i patch the rasbpian code with the Dietpi fix?

@Fourdee

This comment has been minimized.

Copy link
Collaborator

commented Nov 2, 2018

@puccaso

Hi,

We forgot to hold the APT package during install (fixed in v6.18). Raspbian repo updates will replace the pcmanfm package and broken icons will re-appear.

Workaround, is to reinstall the Debian repo (mirrored on our site) pcmanfm with working icons:

wget https://dietpi.com/downloads/binaries/all/pcmanfm_1.2.5-3_armhf.deb
dpkg -i *.deb
@puccaso

This comment has been minimized.

Copy link

commented Nov 3, 2018

hello @Fourdee ,

thanks for getting back to me,

yea, that just segments for me,
im looking in the deb package itself for what is different..
what exactly has been/needs to be change in the source for the RPI guys, maybe i can follow this up with them..

@MichaIng

This comment has been minimized.

Copy link
Owner

commented Nov 3, 2018

@puccaso
This would be great. Always better to solve this dev/maintainer side instead of keeping an unideal workaround.

@MichaIng

This comment has been minimized.

Copy link
Owner

commented Oct 8, 2019

Same issue present on current current RPi Buster image.

@irenegr

This comment has been minimized.

Copy link

commented Oct 10, 2019

Same problem on Raspbian Buster. I found a workaround (?): Pcmanfm->Edit->Preferences->Layout->disable "Display simplified user interface and menus".
Toolbar icons are back again (Papirus icons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.