Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #6

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@Hiobi
Copy link
Contributor

commented May 9, 2019

Hi,
some french in it. :3

French translation
Hi,
some french in it. :3
@MichaelBelgium

This comment has been minimized.

Copy link
Owner

commented May 10, 2019

I appreciate the work but any specific reason why u're not adding it in the french language pack?

I'm not really a fan of having translations in extensions. Fits more if its in a language pack.

@Hiobi

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Hi,
I understand, I'm ok with that.
But it seems that many others developpers prefer to add it to their own repository, not in the language pack. For example, in the french language there is only translation for bundled extensions.

https://github.com/milescellar/lang-french
https://discuss.flarum.org/d/615-french-language-pack/200

@MichaelBelgium

This comment has been minimized.

Copy link
Owner

commented May 10, 2019

Mhm yeah everyone has his own preference ofcourse. But like in the dutch language pack ive put my extensions.

But alright, ill merge it here then

@MichaelBelgium MichaelBelgium merged commit 3bfd3f4 into MichaelBelgium:master May 10, 2019

@Hiobi

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Don’t worry Michael, do what you prefer, I can make PR on French language pack too.
It’s more easier.

Just for notice, now it seems that FoF doesn’t want anymore to accept language’s files PR on their own repository, to prefer language pack.

I’m totally in line with this preference, it’s more easier for everyone. :)

I will make PR on French language pack!
Thanks !

@MichaelBelgium

This comment has been minimized.

Copy link
Owner

commented May 10, 2019

Oooh, well i merged it now, so u don't really have to do. But okay sure, if that PR gets accepted i'll remove it here then

@Hiobi

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

okay! I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.