Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Font Awesome 5 + GraphQL API integration #17

merged 66 commits into from Mar 3, 2021


Copy link

@MickeyKay MickeyKay commented Sep 10, 2020

This PR bumps the underlying Better Font Awesome Library to support Font Awesome v5+ and makes a few additional admin changes. The core changes can be found in the PR description for the Better Font Awesome Library updates. In addition to those changes, this PR also:

  • adds details to the admin plugin settings page to indicate the current (always latest) version of Font Awesome being used, as well as the update check frequency
  • removes the now-deprecated admin options to select 1. Font Awesome version, and 2. minified vs. unminified assets
  • removes deprecated instructions on the admin plugin settings page
  • updates test infrastructure and adds unit tests for the underlying BFA library (@todo move to the lib once testing is configured there)

@MickeyKay MickeyKay merged commit 9d6dd40 into master Mar 3, 2021
2 checks passed
@MickeyKay MickeyKay deleted the feature/fa-5-latest branch Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant