Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of `MicroProfileApplication` since it can be used for any application, also Java EE #63

Closed
rdebusscher opened this issue Sep 17, 2019 · 5 comments · Fixed by #113
Assignees

Comments

@rdebusscher
Copy link
Contributor

@rdebusscher rdebusscher commented Sep 17, 2019

MicroProfileApplication is not the best name since you can just run any application.

But is has some benefits over GenericContainer like detecting the file to deploy, the dockerFile or the Server Adapter.

@rdebusscher

This comment has been minimized.

Copy link
Contributor Author

@rdebusscher rdebusscher commented Sep 17, 2019

Proposal : ApplicationContainer

Since it still is a Container but geared towards your application.

@aguibert

This comment has been minimized.

Copy link
Member

@aguibert aguibert commented Sep 18, 2019

yes I think we certainly need to change it away from MicroProfileApplication, or possibly offer multiple options. that extend a base abstract class.

I like ApplicationContainer, or perhaps just ApplicationRuntime may be more appropriate when not running in containers for hollow mode (see this doc for details)

@yeekangc

This comment has been minimized.

Copy link
Member

@yeekangc yeekangc commented Sep 18, 2019

+1 to either Application, ApplicationContainer or ApplicationRuntime.

Andy, are you thinking that ApplicationRuntime will cover both the container case and hollow mode? Or, we will have both?

@aguibert

This comment has been minimized.

Copy link
Member

@aguibert aguibert commented Sep 18, 2019

One would cover both

@yeekangc

This comment has been minimized.

Copy link
Member

@yeekangc yeekangc commented Sep 19, 2019

IMHO, ApplicationContainer may be slightly better than ApplicationRuntime since MST may support more than "runtimes" but also "frameworks" etc where applications can run in/on. Also, we already configuration for hollow mode already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.