Permalink
Browse files

PR Suggestions

  • Loading branch information...
d3r3kk committed May 2, 2018
1 parent b35f7e2 commit 8c3d355fe46c65e5f2319b3b94feb5cbf2602913
Showing with 7 additions and 25 deletions.
  1. +2 −21 Samples/Heartbeat/AspNetCore/README.md
  2. +5 −4 heartbeat/heartbeat-specification.md
@@ -18,24 +18,7 @@ SHELL> dotnet add .\ASPNetCoreSample.csproj package Microsoft.ApplicationInsight
> Note: The Heartbeat feature is enabled by default as of base SDK 2.5.0 and the
ability to configure the Heartbeat was added in 2.3.0-beta1.
2. Edit the `Program.cs` file located in your ASPNetCoreSample/ASPNetCoreSample
folder. Replace the following code:
````
public static IWebHost BuildWebHost(string[] args) =>
WebHost.CreateDefaultBuilder(args)
.UseStartup<Startup>()
.Build();
````
with this code:
````
public static IWebHost BuildWebHost(string[] args) =>
WebHost.CreateDefaultBuilder(args)
.UseStartup<Startup>()
.UseApplicationInsights()
.Build();
````
3. Edit the `Startup.cs` file located there also, and replace the following
2. Edit the `Startup.cs` file located there also, and replace the following
code:
````
public void ConfigureServices(IServiceCollection services)
@@ -60,7 +43,7 @@ top of your file)
> Note: You can set the `EnableHeartbeat` to false here to disable the heartbeat.
4. Configure the Heartbeat feature in code by modifying the
3. Configure the Heartbeat feature in code by modifying the
`IHeartbeatPropertyManager` directly. You can do this when you first obtain the
property manager via the `TelemetryModules.Instance` singleton.
````
@@ -72,5 +55,3 @@ property manager via the `TelemetryModules.Instance` singleton.
heartbeatPropertyMan.ExcludedHeartbeatProperties.Add("osType");
...
````
@@ -48,7 +48,7 @@ The data that will be included in the Heartbeat by default will be the following
| Name | Type | Example Value | Description |
|------------------------|--------|----------------------|------------------|
| osType | string | Windows" | Operating system of service/application instrumented|
| baseSdkTargetFramework | string | .NET Framework 4.6.2 | The target framework the application was compiled against (to the best of our ability) |
| baseSdkTargetFramework | string | NET46 | The target framework the application was compiled against (to the best of our ability) |
| runtimeFramework | string | 4.0.30319.36366 | Runtime framework version down to patch (as reported by the underlying .NET SDK) |
| processSessionId | GUID | e6f1eaea-486c-4f3b-b20e-8e107d531e43 | Unique GUID for each time the SDK is initialized. User can query this to discover when the app has been restarted. |
---
@@ -58,9 +58,10 @@ We have added some further extensions to the Heartbeat already, and the fields
that they add to the Heartbeat are described below.
### AppServicesHeartbeatTelemetryModule
This module will add some key environment variable values to the Heartbeat that
describe an Azure App Service that has been instrumented with the Application
Insights SDK.
For applications that are deployed on Azure App Services (Web Apps, Azure
Functions) this module will add some key environment variable values to the
Heartbeat that describe an Azure App Service that has been instrumented with
the Application Insights SDK.
| Name | Type | Example Value | Description |
|-----------------|--------|----------------------|------------------|

0 comments on commit 8c3d355

Please sign in to comment.