New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageView should have own ID for proper correlation #361

Open
SergeyKanzhelev opened this Issue Dec 5, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@SergeyKanzhelev
Member

SergeyKanzhelev commented Dec 5, 2016

See Microsoft/ApplicationInsights-dotnet#47 (comment)

We should allow to tie together PageView and Dependencies. So PageView should have own ID field.

@TheXenocide

This comment has been minimized.

Show comment
Hide comment
@TheXenocide

TheXenocide Jan 9, 2017

It seems like maybe PageViewTelemetry should derive from OperationTelemetry, just the same as the other types that have their own ID? DependencyTelemetry and RequestTelemetry are contextual operations that similarly contain traces, exceptions, etc. and PageViewTelemetry.Id would be assigned to root operation ID of associated dependencies via depTelem.Context.Operation.Id which is exactly how operations are nested under other OperationTelemetry as roots (e.g. RequestTelemetry)

TheXenocide commented Jan 9, 2017

It seems like maybe PageViewTelemetry should derive from OperationTelemetry, just the same as the other types that have their own ID? DependencyTelemetry and RequestTelemetry are contextual operations that similarly contain traces, exceptions, etc. and PageViewTelemetry.Id would be assigned to root operation ID of associated dependencies via depTelem.Context.Operation.Id which is exactly how operations are nested under other OperationTelemetry as roots (e.g. RequestTelemetry)

@KamilSzostak KamilSzostak modified the milestones: 1.1.0, 1.0.7 Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment