Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageView should have own ID for proper correlation #361

Closed
SergeyKanzhelev opened this issue Dec 5, 2016 · 2 comments
Closed

PageView should have own ID for proper correlation #361

SergeyKanzhelev opened this issue Dec 5, 2016 · 2 comments

Comments

@SergeyKanzhelev
Copy link

@SergeyKanzhelev SergeyKanzhelev commented Dec 5, 2016

See microsoft/ApplicationInsights-dotnet#47 (comment)

We should allow to tie together PageView and Dependencies. So PageView should have own ID field.

@TheXenocide
Copy link

@TheXenocide TheXenocide commented Jan 9, 2017

It seems like maybe PageViewTelemetry should derive from OperationTelemetry, just the same as the other types that have their own ID? DependencyTelemetry and RequestTelemetry are contextual operations that similarly contain traces, exceptions, etc. and PageViewTelemetry.Id would be assigned to root operation ID of associated dependencies via depTelem.Context.Operation.Id which is exactly how operations are nested under other OperationTelemetry as roots (e.g. RequestTelemetry)

@KamilSzostak KamilSzostak modified the milestones: 1.1.0, 1.0.7 Jan 17, 2017
@jpiyali
Copy link
Contributor

@jpiyali jpiyali commented Jan 16, 2019

This is actually available already today. For each new page in browser, unique id is set for page, that is also propagated as part of dependency data for outgoing requests in dependency id (id = | + pageview.id + util.newid())

@jpiyali jpiyali closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.