Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the story with TrackMetric method #919

Closed
SergeyKanzhelev opened this issue Sep 17, 2018 · 4 comments
Closed

Clean up the story with TrackMetric method #919

SergeyKanzhelev opened this issue Sep 17, 2018 · 4 comments
Assignees
Milestone

Comments

@SergeyKanzhelev
Copy link
Contributor

See http://dajbych.net/why-is-the-application-insights-trackmetric-method-missing for feedback.

There should be a supported way to report an aggregated metric to Application Insights. It may be called differently, but it should exist.

Either TrackMetric should clearly indicate that it is about aggregated metric or the method with new name should be introduced.

@Dmitry-Matveev
Copy link
Member

@dajbych, I read through the article, valid feedback. This was the end result of unending "obsolete" vs. "keep" discussion across several PRs and releases. As it often happens, the middle ground solution turned out confusing..

Sergey/Greg are working to address the overall metrics story/message, this feedback should be covered as part of it.

@EnCey
Copy link

EnCey commented Oct 1, 2018

Please mark the method with [Obsolete] if it is deprecated.

Back-and-forth discussions are one thing, not using Obsolete in favour of XML docs and IntelliSense meddling is quite another. It's like changing the font colour to white instead of deleting something, completely mind boggling. I'd rather learn about a deprecated method in my code base via a compiler warning than having to stumble across it in the docs months later.

@Dmitry-Matveev
Copy link
Member

@EnCey, I agree that this is a confusing end result that does not come in hand with the best practices, @SergeyKanzhelev / @macrogreg are ironing the whole story out and will fix the markings along the way. Thanks for reporting!

@cijothomas
Copy link
Contributor

Fixed with #1153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants