Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd+R/Ctrl+R should refresh the file listing, not reload the whole app viewport #1097

Closed
stewartadam opened this issue Jan 29, 2019 · 7 comments

Comments

@stewartadam
Copy link
Member

@stewartadam stewartadam commented Jan 29, 2019

Storage Explorer Version: 1.6.2
Platform/OS: macOS
Architecture: x64
Regression From: No

Bug description
Conventionally, Cmd+R/Ctrl+R is used to refresh the page. In Storage Explorer, it reloads the whole Electron application and destroys whatever workflow the user had in progress.

Steps to Reproduce

  1. Start doing something in the app (i.e. navigate somewhere)
  2. Press Cmd+R/Ctrl+R

Expected Experience
File listing should refresh itself.

Actual Experience
Whole app reloads, navigating back to root.

@craxal

This comment has been minimized.

Copy link
Contributor

@craxal craxal commented Jan 29, 2019

What you're essentially asking for is a keyboard shortcut for Refresh, correct? We have several places that have a Refresh command, and they all refresh different things. Can you explain in more detail what you mean by "start doing something" so that we have a better idea of what you'd like?

@stewartadam

This comment has been minimized.

Copy link
Member Author

@stewartadam stewartadam commented Jan 31, 2019

What you're essentially asking for is a keyboard shortcut for Refresh, correct?

Yes, and specifically to have it be Cmd/Ctrl+R which is the conventional shortcut for refresh list

We have several places that have a Refresh command, and they all refresh different things

In this case I mean the container's file list (since it doesn't auto-refresh and this is most likely what I want to refresh vs my list of subscriptions, for example)

Can you explain in more detail what you mean by "start doing something" so that we have a better idea of what you'd like?

e.g. open any storage account, browse to a container and start uploading/downloading a file and then hit Ctrl+R/Cmd+R. The whole app viewport reloads (I presume it reinits the Electron app or something) and so progress through any user workflow is lost.

@craxal craxal added this to Committed in Storage Explorer via automation Feb 1, 2019
@craxal craxal added this to the 1.8.0 milestone Feb 1, 2019
@craxal

This comment has been minimized.

Copy link
Contributor

@craxal craxal commented Feb 1, 2019

Thanks! OK, we can add this to our backlog for an upcoming release.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented Mar 4, 2019

When we fix this, don't forget to change reload command to have a new shortcut as well!

@kieronlanning

This comment has been minimized.

Copy link

@kieronlanning kieronlanning commented Mar 8, 2019

I'm going out of my mind with this! I keep CTRL+R'ing and losing my place.

@craxal

This comment has been minimized.

Copy link
Contributor

@craxal craxal commented Mar 8, 2019

@kieronlanning We'll consider this a 👍+1 to getting it fixed. 😉 We've put this in our 1.8.0 milestone.

@kieronlanning

This comment has been minimized.

Copy link

@kieronlanning kieronlanning commented Mar 9, 2019

@craxal Amazing work, thank-you!

I can't seem to fight my muscle memory for this one.

@craxal craxal self-assigned this Apr 3, 2019
@craxal craxal moved this from Committed to Under Review in Storage Explorer Apr 4, 2019
@craxal craxal added the ✔️ merged label Apr 5, 2019
@craxal craxal closed this Apr 5, 2019
Storage Explorer automation moved this from Under Review to Done Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.