Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link "Load more" doesn´t work with the last release to the 1.8.0 #1359

Closed
pasStiga opened this issue May 8, 2019 · 32 comments
Assignees
Labels
Milestone

Comments

@pasStiga
Copy link

@pasStiga pasStiga commented May 8, 2019

Storage Explorer Version: 1.8.0
Platform/OS Version: Windows 10
Architecture: ia32
Build: 20190501.8
Regression From: N/A

Steps to Reproduce:
Expand a classic storage account with 3 containers
Click load more.
Expected Experience:
More containers are loaded.

Actual Experience:
Message loading... is shown and any container appear

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Hi @pasStiga , I'm a little confused. You say the account has 3 containers. Shouldn't there not be a load more? We initially retreive 25 containers when you expand "Blob Containers", so if there's only 3 we should get all at once. Can you share some screenshots with me with what you're seeing?

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

I'm having the same issue. "Load more" isn't working. CosmosDB spins forever without loading anything. And loading Blob from the Azure Portal also causes anything not listed in the first 4-5 items to never show up. I'm seeing this issue cause lag with Azure itself as well. The Blob interface in the portal starts acting strangely while Storage Explorer is doing this infinite load.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

@jccantre are you saying that you're seeing issues in tools other than Storage Explorer? Or are you saying you start seeing issues in other tools after Storage Explorer starts acting weird?

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

Yes. It seems to be affecting the Azure Portal itself. When Storage Explorer is doing the infinite load the Blob portal stops working. Edit: And when I shut down Storage Explorer the portal goes back to normal.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Interesting. Are you also trying to load more blob containers from a classic storage account, or is it a standard storage account? If you're unsure then you can look in the properties panel after selecting your account:
image

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

Microsoft.Storage/storageAccounts

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

This is very odd. Does your company have some sort of screen sharing software we could use with each other? I'd like to debug your machine, because so far we haven't been able to repro this at all. If you don't, then we could use TeamViewer....

I can also give you debugging instructions for you to try on your own:

  1. Close and then reopen Storage Explorer
  2. Open Dev Tools (F12, or help -> toggle developer tools)
  3. Use ctrl+p to open CommonStorageManager.js
  4. Go expand your blob containers node the first time
  5. Go to line 165 in the debugger and click on the line number, should see it turn blue:
    image
  6. Click load more
  7. When the breakpoint is hit, hover over current token and let me know what it says
    image
@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

Unfortunately I'm working for a client and can't screen share. I've opened the dev tools and hit ctrl+p and do not see CommonStorageManager.js.

I have the following:
LocalStorageManager.js
BrowserStorageManager.js
SessionStorageManager.js

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Ah ok, that's possible. Can you expand the Blob Containers node for the first time and then look for the file? I have some containers in Quick Access, so for me the file is loaded on startup. And nbd about not being able to screenshare. I'll do my best to talk back and forth with you here. Very interested to figure out what's giving y'all issues.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

You can also set breakpoints in BlobService.js, at lines 68 and 71:
image
You can set them after the initial expansion of Blob Containers, click Load More, and then we can see if either get hit? If neither ever get hit, then we're looking at a server issue maybe. For that we'll need to break out fiddler...

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

I have containers in Quick Access as well and it doesn't pop up. When I open the resource group, Cosmos DB Accounts, ADLS Gen1, and Storage Accounts are already expanded and there's no CommonStorageManager.js that I can see.

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

And the Cosmos DB load never stops spinning.
image

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

So you see blob containers in the tree but you don't see the file? Because it should definitely be there:
image
That's really strange, but ok, guess we'll go with Fiddler then. Here are the instructions for getting Fiddler setup (unfortunately they're really long, also it assumes you've installed Fiddler, so make sure you have that installed):
image

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

Ok. Now I know why I'm not seeing that js file. I'm not having an issue with Blob Containers. I'm having an issue with Storage Accounts. That js file pops up when I click Blob Containers. My issue is loading Storage Accounts, i.e. the Blob resource not the containers in the resource.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Ok, I guess I'm back to being confused about which load more is failing.
Is it for "Blob Containers":
image
Or is it for "Storage Accounts:"
image
For @pasStiga, I believe they are having issues with the 1st one.

@datascinerd

This comment has been minimized.

Copy link

@datascinerd datascinerd commented May 8, 2019

Storage Accounts

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Ok so if you could do the following:

  1. Launch storage explorer
  2. Get the debug tools to NodeQueryHandler.js (this one should definitely be there right at the beginning)
  3. Expand your tree all the way up to before you expand "Storage Accounts"
  4. Set a breakpoint on line 105
  5. Expand "Storage Accounts"
  6. When the break point is hit, hover over queryResult and let me know how many results there are, and if there's a continuationToken
    image
  7. Click "Load more", if the breakpoint is eventually hit, let me know what is inside of queryResult, if the breakpoint is never hit, then we'll have to look somewhere else next

Also, do you know how many Storage Accounts are in this subscription?

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 8, 2019

Ok. I have a path I think I can investigate. Will work on this diligently. This seems like an urgent issue. Thank your for your patience today.

@jcantrell1

This comment has been minimized.

Copy link

@jcantrell1 jcantrell1 commented May 8, 2019

Thank you!

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 9, 2019

Ok, I have something I'd like you to try.

  1. Close Storage Explorer
  2. Open a text editor as admin (if you use VS Code, you can open it normally, it'll instead prompt you at Save time)
  3. Open "C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\out\CloudHub\js\Providers\Azure\Producers\AzureResourceTypeProducer.js" (path may differ depending on your install location)
  4. On line 52, make it look like this (at the end, continuationToken):
  5. image
  6. Save
  7. Reopen Storage Explorer and try to repro the issue
@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 9, 2019

Also, @pasStiga, please reply to my questions when you can. I don't think you have the same issue as jcantrell, but we didn't make any changes at that level of "loading", only at the level where jcantrell is seeing issues.

@jcantrell1

This comment has been minimized.

Copy link

@jcantrell1 jcantrell1 commented May 9, 2019

Here's the code after the change above:
queryBindingManager.addProducerBinding(AzureResourceTypeProducer.getResourcesByTypeNamespace, function (args) { return _this.getResourcesByType(args,continuationToken); });

And it caused Storage Explorer to not load anything:
image

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 9, 2019

The line should be:
queryBindingManager.addProducerBinding(AzureResourceTypeProducer.getResourcesByTypeNamespace, function (args, continuationToken) { return _this.getResourcesByType(args,continuationToken); });

@jcantrell1

This comment has been minimized.

Copy link

@jcantrell1 jcantrell1 commented May 9, 2019

That fixed it!

@MRayermannMSFT MRayermannMSFT added this to the 1.8.1 milestone May 9, 2019
@MRayermannMSFT MRayermannMSFT self-assigned this May 9, 2019
@pasStiga

This comment has been minimized.

Copy link
Author

@pasStiga pasStiga commented May 10, 2019

Hi @MRayermannMSFT , sorry for the delay. I can try the same that @jcantrell1 but I dont know if it is the same issue

@garygsscott

This comment has been minimized.

Copy link

@garygsscott garygsscott commented May 10, 2019

I have the same issue. It was working fine in 1.7.0. Will try the steps above and see if it resolves the issue.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 10, 2019

Yes, please let us know ASAP. The plan is to ship 1.8.1 today, with the fix for this included. So if y'all are having a different problem, it'd be great to know before shipping! Thanks. 😊

@garygsscott

This comment has been minimized.

Copy link

@garygsscott garygsscott commented May 11, 2019

I have tried the same as @jcantrell1 and can confirm it fixes the issue for me also so we should be good to go when v1.8.1 is made available. Thanks for your help,

@garygsscott

This comment has been minimized.

Copy link

@garygsscott garygsscott commented May 13, 2019

I have just downloaded v1.8.1 from chocolatey and can confirm that issue is definitely fixed for me now in that version. Many thanks for your help on this.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented May 13, 2019

Wohoo good stuff! I'll assume paastiga was under the same umbrella issue wise. Closing this issue.

@pasStiga

This comment has been minimized.

Copy link
Author

@pasStiga pasStiga commented May 14, 2019

Hi,
It was fixed with the new release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.