Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error icon is displayed to the user when there is no error #148

Closed
Liversage opened this issue May 4, 2018 · 5 comments
Closed

An error icon is displayed to the user when there is no error #148

Liversage opened this issue May 4, 2018 · 5 comments
Assignees
Labels
🪲 bug Issue is not intended behavior ✅ merged A fix for this issue has been merged
Milestone

Comments

@Liversage
Copy link

Storage Explorer Version: 1.0.0

Platform: Windows

When I delete a row in an Azure table or the table itself etc. then Azure Storage Explorer will display a message box asking me if I'm sure I want to perform the operation. In this dialog box an icon is displayed:

Dialog box with error icon displayed to prompt the user

With reference to Standard Icons in Design basics for Desktop applications in the Windows Dev Center the icon displayed is an Error icon.

(I know that Azure Storage Explorer doesn't have to follow these design guidelines for Windows applications but in my opinion following these guidelines generally lead to a better user experience. And if for some reason the Azure Storage Explorer team decides to not follow these guidelines you can record that fact in this issue.)

According to the guidelines the error icon should be used for the following message type:

An error or problem that has occurred.

The discussion in the Avoid overwarning section is also relevant even though is about overuse of the warning icon and not the error icon:

The typical Windows program has warning icons seemingly everywhere, warning about things that have little significance. In some programs, nearly every question is presented as a warning. Overwarning makes using a program feel like a hazardous activity, and it detracts from truly significant issues.

Asking me if it is OK to delete something is not an error. The application should either warn or inform me that the operation cannot be undone and not make me feel that I'm doing some kind of hazardous activity.

@craxal craxal assigned craxal and MRayermannMSFT and unassigned craxal May 4, 2018
@craxal craxal added the 🪲 bug Issue is not intended behavior label May 4, 2018
@craxal craxal added this to the 1.1.0 milestone May 4, 2018
@craxal
Copy link
Contributor

craxal commented May 4, 2018

Yeah, we've noticed this before. We just used the wrong icon. We're on it!

@MRayermannMSFT
Copy link
Member

PR is ready.
image

@MRayermannMSFT MRayermannMSFT added pending ✅ merged A fix for this issue has been merged and removed pending labels May 4, 2018
@MRayermannMSFT
Copy link
Member

Merged into rel branch!

@Liversage
Copy link
Author

After installing 1.1.0 I saw to my delight that this issue was resolved. However, while my report used deleting rows in Azure tables as an example I really intended the issue to be about the overuse of the error icon in general. Apparently, this issue was resolved by only changing the icon used when deleting a row in an Azure table but there are many other places in the app when - at least according to my opinion - you use the error icon when you should either use no icon or only use a warning icon because there is no error.

I'm certainly no master of UX so I tend to follow guidelines set forth by people smarter than me and based on the document I quoted in the original issue I would get rid of the icon all together for "minor" destructive operations, use the warning icon for "major" destructive operations and reserve the error icon for error conditions.

I noticed that the error and warning icons have distinct sounds and I'm sure "no icon" has no sound so you might also take that into consideration when designing the UX.

@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented May 14, 2018

Hey @Liversage , thankfully I think we were on the same page about the point of your issue. While I didn't go looking for every system error/warning dialog we pop up to see if the icon was correct/the right level, I have been keeping my eye out when making changes and reviewing other people's changes. In fact, just last week I changed the icon for the clear queue icon to be warning instead of error. So be on the lookout for more dialogs to have their icons changed, and if there is one you feel particularly passionate about, feel free to point it out. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Issue is not intended behavior ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants