Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzCopy doesn't support sovereign cloud environments #1544

Closed
weikhe opened this issue Jul 11, 2019 · 8 comments
Assignees
Milestone

Comments

@weikhe
Copy link

@weikhe weikhe commented Jul 11, 2019

Storage Explorer Version: 1.9.0
Build Number: 20190701.8
Platform/OS: Windows 10
Architecture: x64
Regression From:

Bug Description

Preview feature "Use AzCopy for Improved Blob Upload and Download" doesn't support sovereign cloud environment (Azure China/ Azure Germany/ Azure US Government). If want to upload files in these environments, it will fail, because AzCopy is still using "core.windows.net" domain for target account, which causes key mismatch and upload fails.

The AzCopy command I copied from my local Storage Explorer:
$env:AZCOPY_CRED_TYPE = "Anonymous";
./azcopy.exe copy "<file path>" "https://<account name>.blob.core.windows.net/<.......> --follow-symlinks --recursive --from-to=LocalBlob --blob-type=BlockBlob --put-md5;
$env:AZCOPY_CRED_TYPE = "";

Steps to Reproduce

  1. Add a sovereign environment account (Azure China/ Azure Germany/ Azure US Government).
  2. Enable preview feature "Use AzCopy for Improved Blob Upload and Download"
  3. Upload any files to the account's container

Expected Experience

It should be able to detect account's environment, and change domain in AzCopy commandline accordingly.

Actual Experience

It keeps using "core.windows.net" as account's domain in AzCopy no matter account's real environment, which causes key mismatch and upload fails

Additional Context

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented Jul 15, 2019

Hi @weikhe how did you add the account? Was it via:

  • accessing an account after signing in
  • attaching with name and key
  • attaching with a connection string

Thanks!

@MRayermannMSFT MRayermannMSFT added this to the 1.10.0 milestone Jul 15, 2019
@weikhe

This comment has been minimized.

Copy link
Author

@weikhe weikhe commented Jul 16, 2019

Hi @MRayermannMSFT
I add it via attaching with name and key: "Use a storage account name and key"

@jinglouMSFT

This comment has been minimized.

Copy link

@jinglouMSFT jinglouMSFT commented Jul 16, 2019

We may not have the end points when using name and key. Have you tried to sign-in?

@weikhe

This comment has been minimized.

Copy link
Author

@weikhe weikhe commented Jul 16, 2019

image
We can select endpoints when using name and key (see attached screenshot), and I'm able to view account's contents, download/upload using non-AzCopy way, so I think it's a bug in this AzCopy feature.

This account is not under my subscription, so I'm using name+key to access. But I think even if I use sign-in way, it would still fail due to wrong domain.

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented Jul 16, 2019

Ok, thanks for the followup. I'll get back to you. 😄

@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented Jul 16, 2019

If you sign in, it will work. For your scenario though, I've identified where the issue is and the change we need to make to fix it. Can you wait for 1.10 to come out, or would you like me to give you steps to unblock you now (you'll be editing the app's JavaScript).

@MRayermannMSFT MRayermannMSFT self-assigned this Jul 16, 2019
@MRayermannMSFT MRayermannMSFT added this to Committed in Storage Explorer via automation Jul 16, 2019
@MRayermannMSFT MRayermannMSFT moved this from Committed to Under Review in Storage Explorer Jul 16, 2019
@weikhe

This comment has been minimized.

Copy link
Author

@weikhe weikhe commented Jul 17, 2019

Great, I can wait for 1.10, thanks!

@MRayermannMSFT MRayermannMSFT moved this from Under Review to Done in Storage Explorer Jul 24, 2019
@MRayermannMSFT

This comment has been minimized.

Copy link
Member

@MRayermannMSFT MRayermannMSFT commented Jul 24, 2019

Fixed merged into master for 1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.