New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign out should sign me out and not remember me if I don't explicitly ask to be remembered #976

Closed
carlosscastro opened this Issue Oct 11, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@carlosscastro
Member

carlosscastro commented Oct 11, 2018

Steps:

  • Sign in to Azure
  • Do NOT choose "keep me signed in"
  • Sign out
  • Sign in again: my credentials are remembered and I'm automatically signed in, which I don't want.

The "keep me signed in" checkbox is ignored and assumed always true perhaps?

@justinwilaby

This comment has been minimized.

Show comment
Hide comment
@justinwilaby

justinwilaby Oct 11, 2018

Contributor

Thank for opening this discussion.

The purpose of remember me is not to control whether or not the user is prompted for credentials the login tool. Its purpose is to prevent the user from having to login again if the emulator is closed and reopened at a later time. To implement what you describe, we would need two checkboxes, one to remember credentials in the sign in tool and another to remember the user's azure login at the emulator. The two are mutually exclusive and we currently implement only the latter.

Contributor

justinwilaby commented Oct 11, 2018

Thank for opening this discussion.

The purpose of remember me is not to control whether or not the user is prompted for credentials the login tool. Its purpose is to prevent the user from having to login again if the emulator is closed and reopened at a later time. To implement what you describe, we would need two checkboxes, one to remember credentials in the sign in tool and another to remember the user's azure login at the emulator. The two are mutually exclusive and we currently implement only the latter.

@carlosscastro

This comment has been minimized.

Show comment
Hide comment
@carlosscastro

carlosscastro Oct 11, 2018

Member

The current state doesn't feel right because if I sign in with my work account by mistake, then I sign out with the intention of signing in with my personal account, I cannot - the emulator simply chooses to sign me in to an account that i did not ask to be remembered and I don't want to sign in to.

I got frustrated because of this and I imagined our users might feel equally frustrated. Whether it meets the bar to get it fixed or not, I'm not sure! Lets dicuss in standup :)

Member

carlosscastro commented Oct 11, 2018

The current state doesn't feel right because if I sign in with my work account by mistake, then I sign out with the intention of signing in with my personal account, I cannot - the emulator simply chooses to sign me in to an account that i did not ask to be remembered and I don't want to sign in to.

I got frustrated because of this and I imagined our users might feel equally frustrated. Whether it meets the bar to get it fixed or not, I'm not sure! Lets dicuss in standup :)

@carlosscastro

This comment has been minimized.

Show comment
Hide comment
@carlosscastro

carlosscastro Oct 11, 2018

Member

If we leave the checkboxes as they are, but sign out reprompts for which account you want to sign in, I would be fine with that. That is a more correct behavior, and seems easy enough to fix.

Member

carlosscastro commented Oct 11, 2018

If we leave the checkboxes as they are, but sign out reprompts for which account you want to sign in, I would be fine with that. That is a more correct behavior, and seems easy enough to fix.

@justinwilaby

This comment has been minimized.

Show comment
Hide comment
@justinwilaby

justinwilaby Oct 11, 2018

Contributor

Yes, setting the prompt=consent seems to work. I can implement this

Contributor

justinwilaby commented Oct 11, 2018

Yes, setting the prompt=consent seems to work. I can implement this

@carlosscastro

This comment has been minimized.

Show comment
Hide comment
@carlosscastro

carlosscastro Oct 11, 2018

Member

nice! Fixes the problem, low risk and easy, love it @justinwilaby!

Member

carlosscastro commented Oct 11, 2018

nice! Fixes the problem, low risk and easy, love it @justinwilaby!

@justinwilaby

This comment has been minimized.

Show comment
Hide comment
@justinwilaby

justinwilaby Oct 11, 2018

Contributor

I really appreciate the time you took to discover this issue and start a discussion towards fixing it. Thank you for helping to make the Emulator better!

Contributor

justinwilaby commented Oct 11, 2018

I really appreciate the time you took to discover this issue and start a discussion towards fixing it. Thank you for helping to make the Emulator better!

@carlosscastro

This comment has been minimized.

Show comment
Hide comment
@carlosscastro

carlosscastro Oct 11, 2018

Member

@justinwilaby Sure! However when I find these things, I can help fix them too, no need for you to jump in, we can help :) I file it as issue so we get to discuss what the right thing is 👍

Member

carlosscastro commented Oct 11, 2018

@justinwilaby Sure! However when I find these things, I can help fix them too, no need for you to jump in, we can help :) I file it as issue so we get to discuss what the right thing is 👍

justinwilaby pushed a commit that referenced this issue Oct 11, 2018

justinwilaby added a commit that referenced this issue Oct 11, 2018

Merge pull request #977 from Microsoft/jwilaby/#976-azure-login
#976 - azure sign in tool now prompts for username with each login
@justinwilaby

This comment has been minimized.

Show comment
Hide comment
@justinwilaby

justinwilaby Oct 11, 2018

Contributor

Fixed with #977

Contributor

justinwilaby commented Oct 11, 2018

Fixed with #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment