Emulator gets confused when multiple endpoints in a bot file are given the same id

[johnataylor]

Version

Bot Framework Emulator (V4 PREVIEW) version: 4.0.0-preview.40025

Describe the bug

If you have the same id for multiple endpoints in the bot file the emulator simply uses the last one in the array in the JSON when it makes calls however it displays the distinct endpoint uri and name.

Of course there is a user bug is in the bot file, however, the behavior of the tool makes this very cryptic.

To Reproduce

1. Create a bot file with multiple endpoints, for example 3, but give each the same id.
2. Use the first or second from the displayed list.
3. Firstly you see multiple displayed in the left hand panel and secondly you see the endpoint uri corresponding to the name you picked, however, under the covers the emulator appears to use the last one added.

Expected behavior

Either detected the error and done display the duplicates. Or detect the error in the file when you open it. Or change the data model such that the user provided id is not critical here.

[justinwilaby]

I have been in discussion with the team regarding BotFile validation and it seems we all agree this is the responsibility of the MSBot utility since all save/load/patch operations are piped through it.

This is a case-and-point example of the rationale I presented when discussing this. The Emulator cannot know all the ways a BotFile can fail without a schema to validate against. We need a validation tool that prevents the user from opening an invalid file or we need to change the format of the BotFile to a binary one and only allow editing via the Emulator or MSBot.

[sgellock]

the tool should generate unique names when writing display name ids