Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue that was crashing app when opening a transcript from the … #1269

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

tonyanziano commented Jan 28, 2019

…command line.

===

Fix for #1257

===

Transcripts being opened from the command line were incorrectly using the same code pattern as transcripts being opened from a remote URL via protocol.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2019

Pull Request Test Coverage Report for Build 1939

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 49.692%

Totals Coverage Status
Change from base Build 1935: 0.004%
Covered Lines: 4445
Relevant Lines: 8354

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/#1257-transcript branch from 03e0a8a to 053010d Jan 28, 2019

@tonyanziano tonyanziano merged commit 298a681 into master Jan 29, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 49.692%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1257-transcript branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.