Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme menu state on mac #1280

Merged
merged 6 commits into from Feb 1, 2019

Conversation

3 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Feb 1, 2019

closes #1239

On a mac, the radio type UI is the exact same as checkbox type, but functions correctly. This has not effect on Windows or Linux.

@a-b-r-o-w-n a-b-r-o-w-n added the 4.3 label Feb 1, 2019

@a-b-r-o-w-n a-b-r-o-w-n added this to In-flight in 4.3 Prioritization via automation Feb 1, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2019

Pull Request Test Coverage Report for Build 1967

  • 3 of 5 (60.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 50.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/main.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 1966: 0.03%
Covered Lines: 4508
Relevant Lines: 8352

💛 - Coveralls

4.3 Prioritization automation moved this from In-flight to Review Feb 1, 2019

@tonyanziano
Copy link
Contributor

tonyanziano left a comment

Nice!

a-b-r-o-w-n added some commits Feb 1, 2019

@a-b-r-o-w-n a-b-r-o-w-n merged commit 45124e2 into Microsoft:master Feb 1, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.303%
Details
license/cla All CLA requirements met.
Details

4.3 Prioritization automation moved this from Review to Done Feb 1, 2019

@a-b-r-o-w-n a-b-r-o-w-n deleted the a-b-r-o-w-n:fix-theme-menu branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.