Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken luis inspector. #1334

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

tonyanziano commented Feb 27, 2019

Fixes #1328

(Also fixed broken emulator.spec.tsx unit tests that were caused by PR #1325)

===

TraceActivity definition wasn't even in the codebase anymore, so I added it back.

NOTE: This is a short-term fix. For a long-term fix, I think we should make the sdk-shared package agnostic to the JS environment (node / browser). That action item is tracked here #1333.

@tonyanziano tonyanziano force-pushed the toanzian/#1328-luis branch 2 times, most recently from 9d81cfa to 14cd403 Feb 27, 2019

@tonyanziano tonyanziano force-pushed the toanzian/#1328-luis branch from 14cd403 to ac64e8f Feb 28, 2019

@tonyanziano tonyanziano merged commit 97cf0ed into v4.3 Feb 28, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 54.932%
Details
license/cla All CLA requirements met.
Details

@stevengum stevengum referenced this pull request Mar 6, 2019

Closed

Emulator reporting #1347

@tonyanziano tonyanziano deleted the toanzian/#1328-luis branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.