Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not render certain activity types in webchat #1363

Merged
merged 2 commits into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Mar 8, 2019

fixes #1358

Fixed

  • [client] Do not render certain activities in webchat in PR #1363

a-b-r-o-w-n added some commits Mar 8, 2019

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review Mar 8, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 2178

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 54.977%

Totals Coverage Status
Change from base Build 2173: 0.01%
Covered Lines: 4873
Relevant Lines: 8324

💛 - Coveralls

@cwhitten cwhitten merged commit 7c49920 into Microsoft:master Mar 10, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 54.977%
Details
license/cla All CLA requirements met.
Details

@a-b-r-o-w-n a-b-r-o-w-n deleted the a-b-r-o-w-n:webchat-do-not-render-trace branch Mar 11, 2019

justinwilaby added a commit that referenced this pull request Mar 11, 2019

cwhitten added a commit that referenced this pull request Mar 11, 2019

Fixes #1283 - opening a bot that has moved should show a message (#1360)
* Fixes #1283 - opening a bot that has moved should show a message

* Linting fix

* Moved imports back to proper location

* Lint

* Fixes #1363 Native dialogs no longer display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.