Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with contentUrl for attachments. #1364

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

tonyanziano commented Mar 8, 2019

Fixes #1362

===

Also moved the service url declaration out of the for loop so that it's not unnecessarily generated for every item.

image

@tonyanziano tonyanziano force-pushed the toanzian/#1362-contenturl branch from 7ce2411 to 9ec1e01 Mar 8, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 2192

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.977%

Totals Coverage Status
Change from base Build 2186: 0.0%
Covered Lines: 4873
Relevant Lines: 8324

💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n merged commit 38d8136 into master Mar 11, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 54.977%
Details
license/cla All CLA requirements met.
Details

@a-b-r-o-w-n a-b-r-o-w-n deleted the toanzian/#1362-contenturl branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.