Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled telemetry and fixed tslint errors. #1375

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

tonyanziano commented Mar 14, 2019

Was getting some tslint errors from d.ts files from sdk/ui-react now that they are being imported properly from #1368, so I fixed them.

I also cherry picked the disable telemetry commit from the v4.3 branch.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 14, 2019

Pull Request Test Coverage Report for Build 2230

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 55.108%

Totals Coverage Status
Change from base Build 2228: 0.1%
Covered Lines: 4875
Relevant Lines: 8316

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/disable-telem branch from df3a3f6 to 5c8621f Mar 14, 2019

@tonyanziano tonyanziano merged commit 2cbf9c3 into master Mar 14, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 55.108%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/disable-telem branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.