Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a lot of LUIS inspector style issues. #1399

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Mar 28, 2019

Fixes #1389, #1390, #1391, #1392

===

Summary of changes

  • Added spacing between "Recognizer Result" & "Raw Result" buttons
  • Removed   from entity viewer HTML and fixed formatting
  • Added correct text color theming to entity editor
  • Fixed inspector header text clipping
  • Added unauthorized log message when LUIS is not configured and trying to inspect a trace
  • Removed Unauthorized text from header when LUIS is not configured
  • Changed version header text to "Unknown" when LUIS is not configured

UI when LUIS is configured

Light
luis-configured

Dark
luis-configured-dark

High Contrast
luis-configured-hc


UI when LUIS is not configured

Light
luis-unconfigured

Dark
luis-unconfigured-dark

High Contrast
luis-unconfigured-hc


EDIT:

Added deep link to configure luis service:

image

@tonyanziano tonyanziano force-pushed the toanzian/luis branch from df4c675 to a5b9b3b Mar 29, 2019

@tonyanziano tonyanziano marked this pull request as ready for review Mar 29, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 29, 2019

Pull Request Test Coverage Report for Build 2268

  • 11 of 27 (40.74%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 55.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/log/logEntry.tsx 3 4 75.0%
packages/extensions/luis/client/src/Controls/Header/Header.tsx 0 1 0.0%
packages/extensions/luis/client/src/App.tsx 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
packages/extensions/luis/client/src/App.tsx 1 0.0%
Totals Coverage Status
Change from base Build 2262: 0.2%
Covered Lines: 4893
Relevant Lines: 8321

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/luis branch from a5b9b3b to 9b5cd33 Mar 29, 2019

@justinwilaby
Copy link
Contributor

left a comment

Themes specific to this extension should probably be located in the extension's project.

Show resolved Hide resolved packages/app/client/src/ui/styles/themes/light.css Outdated

@tonyanziano tonyanziano force-pushed the toanzian/luis branch from 84c16fd to 2bf70fd Apr 1, 2019

@tonyanziano tonyanziano force-pushed the toanzian/luis branch from 2bf70fd to e155896 Apr 1, 2019

@tonyanziano tonyanziano requested a review from justinwilaby Apr 1, 2019

@justinwilaby
Copy link
Contributor

left a comment

:shipit:
LGTM

@tonyanziano tonyanziano merged commit 1c2b589 into master Apr 2, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+4.8%) to 55.411%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/luis branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.