Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar debugging - Milestone 0.9 #1400

Merged
merged 35 commits into from Apr 22, 2019

Conversation

Projects
None yet
5 participants
@justinwilaby
Copy link
Contributor

commented Mar 28, 2019

"Sidecar" Debugger progress

@justinwilaby

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

image

@a-b-r-o-w-n
Copy link
Contributor

left a comment

I'll need to give this a functional whirl, but I did have some comments.

@justinwilaby justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 5a9590d to f02db84 Apr 5, 2019

@a-b-r-o-w-n
Copy link
Contributor

left a comment

I'm a little concerned that the diffing is tightly coupled to the presentation logic. It is pretty brittle at the moment. See my comment about moving the presentational logic into the extension itself.

@a-b-r-o-w-n
Copy link
Contributor

left a comment

Can you share a screenshot of the json view with diff mode enabled?

@justinwilaby justinwilaby force-pushed the jwilaby/auto-connect-emulator branch 2 times, most recently from 89754c0 to 5a889d0 Apr 11, 2019

@justinwilaby justinwilaby marked this pull request as ready for review Apr 15, 2019

@justinwilaby justinwilaby requested review from compulim and corinagum as code owners Apr 15, 2019

@justinwilaby justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 6fe0c29 to bed40fc Apr 15, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 15, 2019

Pull Request Test Coverage Report for Build 2447

  • 518 of 665 (77.89%) changed or added relevant lines in 71 files are covered.
  • 21 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+1.3%) to 56.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/data/sagas/botSagas.ts 6 7 85.71%
packages/app/client/src/index.tsx 0 1 0.0%
packages/app/client/src/ui/shell/mdi/tabBar/tabBar.tsx 0 1 0.0%
packages/app/client/src/ui/shell/mdi/tabBar/tabBarContainer.ts 1 2 50.0%
packages/app/client/src/ui/shell/navBar/navBar.tsx 2 3 66.67%
packages/app/main/src/botHelpers.ts 5 6 83.33%
packages/app/shared/src/enums/index.ts 0 1 0.0%
packages/emulator/core/src/facility/conversationSet.ts 5 6 83.33%
packages/emulator/core/src/utils/activityVisitor.ts 1 2 50.0%
packages/app/client/src/extensions.ts 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
packages/app/main/src/main.ts 1 0.0%
packages/app/main/src/commands/oauthCommands.ts 1 0.0%
packages/app/main/src/commands/emulatorCommands.ts 1 81.37%
packages/app/client/src/ui/shell/navBar/navBar.tsx 1 79.17%
packages/app/client/src/ui/editor/emulator/emulator.tsx 1 83.1%
packages/emulator/core/src/facility/conversation.ts 1 64.29%
packages/sdk/shared/src/utils/json2HTML.ts 1 0.0%
packages/emulator/cli/src/npmLogger.ts 1 0.0%
packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx 2 85.96%
packages/emulator/core/src/directLine/middleware/startConversation.ts 2 61.9%
Totals Coverage Status
Change from base Build 2399: 1.3%
Covered Lines: 5241
Relevant Lines: 8676

💛 - Coveralls

@justinwilaby justinwilaby requested a review from a-b-r-o-w-n Apr 15, 2019

@justinwilaby justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 94302a0 to a62e51a Apr 15, 2019

@cwhitten cwhitten changed the title Jwilaby/auto connect emulator Sidecar debugging - Milestone 0.9 Apr 16, 2019

Discussed waiting to move code until after release

endpointUrl: endpoint.endpoint,
userId: currentUserId,
conversationId,
// directLine: createDirectLine({

This comment has been minimized.

Copy link
@justinwilaby

justinwilaby Apr 17, 2019

Author Contributor

placeholder to refactor createDirectLine out of emulator.tsx and into this command. Code is commented out but works in preliminary tests.

stale

@cwhitten
Copy link
Member

left a comment

pending internal QA issues

tonyanziano and others added some commits Apr 19, 2019

Drill livechat mode (#1438)
* Allows injection of Conversation "mode" to support conversations started via connecting by url.

* Clean up the types

* Fix a test
Save transcript fix (#1440)
* Changes to support saving a transcript for a conversation opened via url

* add tests for getTranscriptsPath

* Lint issue

* Add some additional typings

* Lint fixes
Merge branch 'jwilaby/auto-connect-emulator' of github.com:Microsoft/…
…BotFramework-Emulator into jwilaby/auto-connect-emulator

@cwhitten cwhitten merged commit ce2b783 into master Apr 22, 2019

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 56.787%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@cwhitten cwhitten deleted the jwilaby/auto-connect-emulator branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.