Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of node Buffer() deprecation warnings. #1426

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Apr 12, 2019

As a side effect of bumping Electron a new node deprecation warning has surfaced. This fixes it.

image

@coveralls

This comment has been minimized.

Copy link

commented Apr 12, 2019

Pull Request Test Coverage Report for Build 2495

  • 1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/emulator/core/src/facility/conversation.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 2493: 0.0%
Covered Lines: 5252
Relevant Lines: 8686

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/buffer-warning branch from 8c8c528 to 8626e18 Apr 15, 2019

@tonyanziano tonyanziano force-pushed the toanzian/buffer-warning branch from 8626e18 to dc5a9ef Apr 23, 2019

@tonyanziano tonyanziano force-pushed the toanzian/buffer-warning branch from dc5a9ef to 1940c0c Apr 23, 2019

@tonyanziano tonyanziano merged commit 9af5a5d into master Apr 23, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 56.83%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/buffer-warning branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.