Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed custom user agent string from outgoing requests. #1427

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Apr 12, 2019

Fixes #1248

===

This reverts #1092 as the custom user agent does not apply to outgoing requests from the extensions, however, Electron automatically attaches one of the form BotFrameworkEmulator/{version} to all outgoing requests originating in the app.

@coveralls

This comment has been minimized.

Copy link

commented Apr 12, 2019

Pull Request Test Coverage Report for Build 2381

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 55.459%

Totals Coverage Status
Change from base Build 2379: 0.01%
Covered Lines: 4894
Relevant Lines: 8317

💛 - Coveralls
@coveralls

This comment has been minimized.

Copy link

commented Apr 12, 2019

Pull Request Test Coverage Report for Build 2362

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 55.42%

Totals Coverage Status
Change from base Build 2348: -0.001%
Covered Lines: 4892
Relevant Lines: 8318

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/#1248 branch 2 times, most recently from 7b36acb to 8f1b93c Apr 12, 2019

@tonyanziano tonyanziano merged commit 413cfd5 into master Apr 15, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 55.459%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1248 branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.