Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tab icons #1428

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Apr 15, 2019

Fixes #1228. Also fixes the incorrect styling of the bot explorer.

===

tabs1

tabs2

tabs3


badpane

goodpane

@tonyanziano tonyanziano force-pushed the toanzian/#1228-tabs branch from 85faadd to 2a0a664 Apr 15, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 15, 2019

Pull Request Test Coverage Report for Build 2389

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 55.489%

Totals Coverage Status
Change from base Build 2383: 0.03%
Covered Lines: 4899
Relevant Lines: 8322

💛 - Coveralls
@a-b-r-o-w-n
Copy link
Contributor

left a comment

I'm getting lint errors running npm run build at the root. Weird because CI is passing.

@a-b-r-o-w-n
Copy link
Contributor

left a comment

Well, it is failing on master too. I don't have the bandwidth to investigate at the moment though 👎

@tonyanziano tonyanziano merged commit 1d6480e into master Apr 15, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 55.489%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1228-tabs branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.