Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error thrown when cancelling opening a transcript. #1441

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Apr 22, 2019

Fixes #1432

@tonyanziano tonyanziano force-pushed the toanzian/#1432-xs branch from f51279b to cce7f86 Apr 22, 2019

@tonyanziano tonyanziano changed the title Fixed error thrown when cancelling open a transcript. Fixed error thrown when cancelling opening a transcript. Apr 22, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 22, 2019

Pull Request Test Coverage Report for Build 2454

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/emulatorCommands.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 2448: 0.0%
Covered Lines: 5242
Relevant Lines: 8677

💛 - Coveralls

@tonyanziano tonyanziano merged commit 054f455 into master Apr 22, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 56.789%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1432-xs branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.