Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed opening a livechat session via protocol. #1446

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

commented Apr 23, 2019

Fixes #1420

@tonyanziano tonyanziano force-pushed the toanzian/#1420-protocol branch from a1ab82b to 4deb3a5 Apr 23, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 23, 2019

Pull Request Test Coverage Report for Build 2476

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 56.791%

Files with Coverage Reduction New Missed Lines %
packages/app/main/src/protocolHandler.ts 2 81.22%
Totals Coverage Status
Change from base Build 2472: -0.004%
Covered Lines: 5250
Relevant Lines: 8685

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/#1420-protocol branch from 4deb3a5 to 6d94533 Apr 23, 2019

@tonyanziano tonyanziano merged commit bfdbda8 into master Apr 23, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 56.83%
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1420-protocol branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.