New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OAuthCards (real and mocked) #433

Merged
merged 5 commits into from May 1, 2018

Conversation

Projects
None yet
2 participants
@Jeffders
Member

Jeffders commented Apr 19, 2018

This change includes support for OAuthCard handling:

  1. There is an online version that does the full OAuth flow to login and return a token to the bot. This uses the PKCE protocol to avoid the need for the magic code in WebChat. PKCE is a way of injecting a code_verifier during the final OAuth redirect for validating the client that received the link is the only one that can click on it.

  2. A mocked version that returns a fake token.

@Jeffders Jeffders merged commit aa6c640 into master May 1, 2018

1 check passed

license/cla All CLA requirements met.
Details

@justinwilaby justinwilaby deleted the jeffders/OAuthCards branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment