Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility of anchors and sample improvements #1710

Merged
merged 25 commits into from Feb 12, 2019
Merged

Accessibility of anchors and sample improvements #1710

merged 25 commits into from Feb 12, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Feb 8, 2019 •
edited

Fix #1681
Partial fix for #1444

  • Make links in our README.md's more accessible
  • Add README.md's to samples 05-10.
  • Update samples to remove height and width specification

@corinagum corinagum mentioned this pull request Feb 8, 2019
Closed
23 tasks
@coveralls
Copy link

coveralls commented Feb 8, 2019 •
edited

Coverage Status

Coverage decreased (-0.04%) to 54.423% when pulling f3eac78 on corinagum:corinagum/1444-b into da8aef4 on Microsoft:master.

@corinagum
Copy link
Contributor Author

Restarting build due to timeout error.

@corinagum corinagum changed the title [DRAFT] Accessibility of anchors and sample improvements Accessibility of anchors and sample improvements Feb 9, 2019
@compulim
Copy link
Contributor

compulim commented Feb 12, 2019 •
edited

Rebased, waiting for build to succeed before squash merge.

@compulim compulim merged commit 28b4e4d into microsoft:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix accessibility of anchors in across repo (including README's)
4 participants
@corinagum @coveralls @compulim @tonyanziano