Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAL: wfopen support longer mode strings and improve compatibility #3176

Open
obastemur opened this issue Jun 17, 2017 · 1 comment

Comments

Projects
None yet
5 participants
@obastemur
Copy link
Member

commented Jun 17, 2017

Extracted from #3159

_wfopen_s's implementation here limits the mode to 10 chars - so calling _wfopen with "r, ccs=UNICODE" fails since the mode string is longer than 10 chars.

@obastemur obastemur changed the title PAL: wfopen Unicode compatibility PAL: wfopen support longer mode strings and improve compatibility Jun 17, 2017

@digitalinfinity

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

There is another issue that is noted in #3159 that should also be fixed up here- MapFileOpenModes does not like it if ccs=UNICODE is passed in as the mode string. This should also be fixed as part of fixing this issue. If this is implemented, then ConfigParser::ParseConfig can be updated to not be ifdefed separately for Windows and Linux for the wfopen_s call.

@dilijev dilijev added the help wanted label Jan 17, 2018

@MikeHolman MikeHolman added this to the Backlog milestone May 7, 2018

@MikeHolman MikeHolman removed the Needs Triage label Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.