Remove EnableJitInDiagMode from the code

[obastemur]

It's an unused broken flag. We better remove it from the code and test cases. Long story short, if JIT is enabled, it's also enabled for Debugger and there is no another supported option.

[akroshg]

Yup.

[fatcerberus]

if JIT is enabled, it's also enabled for Debugger

Is this actually the case in practice? It’s been my experience based on performance assessments that attaching the debugger switches execution to a fully interpreted mode with no JIT.

[tanya-vedi]

I want to take up this issue.

[obastemur]

@tanya-vedi , it’s yours. Go ahead and send the PR

[tanya-vedi]

Thanks! I'm a beginner, can someone help me with this?

[obastemur]

Is this actually the case in practice?

@fatcerberus JIT debugging was disabled on xplat. Now it’s enabled again on both master and release 1.9

I'm a beginner, can someone help me with this?

@tanya-vedi feel free to ask your questions here. I have no doubt that ChakraCore contributors will gladly answer them.

[tanya-vedi]

If anyone can help me proceed with this issue, then it would be great.

[ajomadlabs]

Is there anyone working on this ?

[fatcerberus]

@ajomadlabs Yes, see #4657 (which in fact is linked above).

[championshuttler]

Can i take this up if some is not working on it. It seems like there is a PR against this issue but its quite old and not updated from a while

[digitalinfinity]

@mhaviv are you still planning on working on #4657?

[mhaviv]

Hi Hitesh, Unfortunately I have not had the time and I cannot work on it. You can give the task to someone else. I apologize for any inconvenience - Michael

…

Sent from my iPhone

On Oct 25, 2018, at 11:45 PM, Hitesh Kanwathirtha ***@***.***> wrote: @mhaviv are you still planning on working on #4657? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[digitalinfinity]

@mhaviv no worries. @championshuttler it's yours to grab. You can probably just start from #4657.