Linux to Master #1526

Merged
merged 35 commits into from Sep 2, 2016

Projects

None yet

9 participants

@obastemur
Member

No description provided.

antonmes and others added some commits Aug 5, 2016
@antonmes antonmes Change how PAL file I/O functions treat symbolic links
* synchronize changes made in dotnet/coreclr#4922
d8c8141
@digitalinfinity digitalinfinity [MERGE #1393 @antonmes] Change how PAL file I/O functions treat symbo…
…lic links

Merge pull request #1393 from antonmes:linux

Synchronize changes made by @adityamandaleeka in dotnet/coreclr#4922

Fixes build on macOS Sierra:
`ChakraCore/pal/src/cruntime/filecrt.cpp:355:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]`
10fbe7b
@obastemur obastemur cross-platform: fix biops test output for xplat
aacc5fa
@obastemur obastemur cross-platform: fix standard output bus error [pal] and format precision
issue: slow running, JSON/simple.withLog test was randomly failing on xplat.

We provide string length internally. However customized PAL interface expects null ending.

Apart from the fix, also removed unused PAL source files.
8a80aa7
@obastemur obastemur [MERGE #1423 @obastemur] cross-platform: fix standard output bus erro…
…r [pal] and format precision

Merge pull request #1423 from obastemur:unused

issue: [slow running] JSON/simple.withLog test was randomly failing on xplat. [also crashing]

CC provides string length internally. However customized PAL interface expects null ending.

Apart from the fix, also removed unused PAL source files.
8266bda
@obastemur obastemur [MERGE #1414 @obastemur] cross-platform: fix biops test output for xplat
Merge pull request #1414 from obastemur:fix_biops_test
8e9a2dd
@obastemur obastemur Merge remote-tracking branch 'origin/master' into linux
88147d8
@obastemur obastemur cross-platform: fix static/shared build caching
Cmake fails to update references
e633e2d
@obastemur obastemur [MERGE #1430 @obastemur] Merge Master to Linux
Merge pull request #1430 from obastemur:m_merge
b76898e
@obastemur obastemur [MERGE #1431 @obastemur] cross-platform: fix static/shared build caching
Merge pull request #1431 from obastemur:fix_cmake_cache

Cmake fails to update references
d34591d
@Fishrock123 Fishrock123 mac: compile errors are now warnings
8044e29
@obastemur obastemur Merge remote-tracking branch 'origin/master' into linux
fac64fc
@obastemur obastemur [MERGE #1443 @obastemur] Merge Master to Linux
Merge pull request #1443 from obastemur:linux_merge_master_3
9ec833b
@obastemur obastemur [MERGE #1442 @Fishrock123] Fix some mac compile errors (now just warn…
…ings)

Merge pull request #1442 from Fishrock123:fix-mac-compile-errors

Fixes Microsoft#1436
545dd6c
@obastemur obastemur cross-platform: fix memmove for overlapping memory cases
Also added a simple sort test to trigger hybrid_sort implementation
6238513
@obastemur obastemur CH embeds platform details to enable/disable some tests
See comments on disabled test case
8f9d334
@obastemur obastemur [MERGE #1455 @obastemur] CH embeds platform details to enable/disable…
… some tests

Merge pull request #1455 from obastemur:ch_platform

See comments on disabled test case

Attempt to fix #1397
ff1fc68
@obastemur obastemur cross-platform: macOS dylib (shared library) support [passing all the…
… tests]
3cf244f
@obastemur obastemur [MERGE #1473 @obastemur] cross-platform: macOS dylib (shared library)…
… support [all tests pass]

Merge pull request #1473 from obastemur:osx_dylib
bb44f40
@obastemur obastemur cross-platform: Fix external build break and add native testing
We have been keep breaking the native sample project.
Fixing the break and adding a native test to make sure we do not break it again
172e159
@obastemur obastemur [MERGE #1450 @obastemur] cross-platform: fix memmove for overlapping …
…memory cases

Merge pull request #1450 from obastemur:fix_memmove

Also added a simple sort test to trigger hybrid_sort implementation
03111db
@obastemur obastemur [MERGE #1479 @obastemur] cross-platform: Fix external build break and…
… add native testing

Merge pull request #1479 from obastemur:fix_lnx_break

We've been keep breaking the native sample project.
Fixing the break and adding a native test to make sure we do not break it again

new WScript.Platform members : 'LINK_TYPE' and 'BINARY_PATH'
08d65f6
@obastemur obastemur macos: target min osx sdk is 10.7
Some of the embedders (i.e. node-chakracore targets an earlier version of SDK)
ee63338
@obastemur obastemur [MERGE #1493 @obastemur] macos: target min osx sdk is 10.7
Merge pull request #1493 from obastemur:osx_108

Some of the embedders (i.e. node-chakracore targets an earlier version of SDK)
5397df1
@obastemur obastemur runtests.py: default timeout for slow running tests 180 secs on *nix
Some of the tests (slow running) randomly fails on default timeout.
Although timeout can be set from command line for different set of runs,
it is convenient to have a bigger timeout for slow running tests

Affects `--include-slow` runs on unix/posix
6ccc750
@obastemur obastemur [MERGE #1452 @obastemur] runtests.py: default timeout for slow runnin…
…g tests 180 secs on *nix

Merge pull request #1452 from obastemur:running_slow

Some of the tests (slow running) randomly fails on default timeout.
Although timeout can be set from command line for different set of runs,
it is convenient to have a bigger timeout for slow running tests

Affects `--include-slow` runs on unix/posix
f27f483
@obastemur obastemur cross-platform: pthread_attr_get_np false asserts
Saw this while fixing Regex fail on Fedora
395fb6f
@obastemur obastemur cross-platform: va_end may not be no-op
Standard requires a call to va_end due to its undefined behavior.
5396bd7
@obastemur obastemur cross platform: Fix file descriptor leak on PAL_IsDebuggerPresent
Also submitted a PR to coreclr to fix the same issue there.
This PR fixes the Regex/BoiHardFail.js on Fedora.
Now we have all the tests are passing on Fedora
b5e6a83
@obastemur obastemur [MERGE #1508 @obastemur] cross platform: Fix file descriptor leak on …
…PAL_IsDebuggerPresent

Merge pull request #1508 from obastemur:fix_fd_leak

Also submitted a PR to coreclr to fix the same issue there. See dotnet/coreclr#6958
This PR fixes the Regex/BoiHardFail.js on Fedora. See #1334
Now we have all the tests are passing on Fedora
369c33c
@obastemur obastemur [MERGE #1506 @obastemur] cross-platform: pthread_attr_get_np false as…
…serts

Merge pull request #1506 from obastemur:false_assert

Saw this while fixing Regex fail on Fedora
bf1ffbd
@obastemur obastemur [MERGE #1507 @obastemur] cross-platform: va_end may not be no-op
Merge pull request #1507 from obastemur:va_leaks

Standard requires a call to va_end due to its undefined behavior.
1852e9d
@obastemur obastemur referenced this pull request Sep 1, 2016
Closed

Merge Master to Linux #1524

@obastemur obastemur Merge remote-tracking branch 'origin/master' into 'linux'
f053cae
@obastemur
Member

@agarwal-sandeep please review last commit

From this PR forward we won't be using linux branch.

/cc @liminzhu we may want to update Wiki and other places?
/cc @kunalspathak master is ready

/cc @digitalinfinity @jianchun

@agarwal-sandeep agarwal-sandeep and 2 others commented on an outdated diff Sep 1, 2016
...p_in_from_interpreted_function_attach.js.dbg.baseline
@@ -2,19 +2,19 @@
{
"callStack": [
{
- "line": 27,
+ "line": 29,
@agarwal-sandeep
agarwal-sandeep Sep 1, 2016 Contributor

Since you changed the lines in file you will also need to update full repro baseline at [FullRepro]\unittest\DebuggerCommon\step_in_from_interpreted_function_attach.js.dbg.baseline. And since you need to update full baseline you may not do delete WScript.Platform and have Platform show in dbg baseline

@obastemur
obastemur Sep 1, 2016 Member

WScript.Platform is specific to ch

@obastemur
obastemur Sep 1, 2016 Member

Another solution is enabling WScript.Platform only when a specific ch flag is used though. This way we won't have similar issues going forward

@agarwal-sandeep
agarwal-sandeep Sep 1, 2016 Contributor

If WScript.Platform is not needed for majority of the cases then exposing it under a switch is ideal otherwise update the core baseline without modifying the test.

@jianchun
jianchun Sep 1, 2016 edited Member

I wish we could arbitrarily ignore certain objects from all our baselines: WScript, Debug, ... (may we attach and examine a special property, e.g. hide object data completely if it has property __hide_baseline__?)

@agarwal-sandeep
agarwal-sandeep Sep 1, 2016 Contributor

We do but only at top level under locals. Maybe we can revisit and fix ignoring at all levels.

@liminzhu
Member
liminzhu commented Sep 1, 2016

@obastemur gotcha. After it's merged I'll point docs to master branch instead of Linux.

obastemur added some commits Sep 1, 2016
@obastemur obastemur Update step_in_interpreted* test baseline to new WScript
7863d2c
@obastemur @obastemur obastemur Merge branch 'master' into linux [rebase]
b511c5a
@obastemur
Member

@agarwal-sandeep Thanks for the review

@chakrabot chakrabot merged commit b511c5a into Microsoft:master Sep 2, 2016

21 checks passed

Copyright Check Build finished.
Details
EOL Check Build finished.
Details
OSX osx_osx_debug_static Build finished.
Details
OSX osx_osx_release_static Build finished.
Details
OSX osx_osx_test_static Build finished.
Details
Pre-Merge signing tool Sign-off
Details
Ubuntu ubuntu_linux_debug Build finished.
Details
Ubuntu ubuntu_linux_debug_static Build finished.
Details
Ubuntu ubuntu_linux_release Build finished.
Details
Ubuntu ubuntu_linux_release_static Build finished.
Details
Ubuntu ubuntu_linux_test Build finished.
Details
Ubuntu ubuntu_linux_test_static Build finished.
Details
Windows arm_debug Build finished.
Details
Windows arm_release Build finished.
Details
Windows arm_test Build finished.
Details
Windows x64_debug Build finished.
Details
Windows x64_release Build finished.
Details
Windows x64_test Build finished.
Details
Windows x86_debug Build finished.
Details
Windows x86_release Build finished.
Details
Windows x86_test Build finished.
Details
@chakrabot chakrabot pushed a commit that referenced this pull request Sep 2, 2016
@obastemur obastemur [MERGE #1526 @obastemur] Linux to Master
Merge pull request #1526 from obastemur:mmerge_10
996a532
@obastemur obastemur deleted the obastemur:mmerge_10 branch Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment