Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

April servicing update for ChakraCore #6087

merged 8 commits into from Apr 9, 2019


  • Loading branch information...
pleath authored and akroshg committed Feb 7, 2019
commit 4cb3bbd332f67947fab5f4306d75d0749ea4d5fc
@@ -139,7 +139,7 @@ namespace Js
PropertyString* propertyString = scriptContext->GetPropertyString(*propertyId);
*propertyStringName = propertyString;
T dataSlot = descriptor.template GetDataPropertyIndex<false>();
if (dataSlot != NoSlots && (attribs & PropertyWritable))
if (dataSlot != NoSlots && (attribs & PropertyWritable) && type == typeToEnumerate)
PropertyValueInfo::SetCacheInfo(info, propertyString, propertyString->GetLdElemInlineCache(), false);
SetPropertyValueInfo(info, instance, dataSlot, &descriptor);
@@ -328,7 +328,7 @@ namespace Js
*propertyStringName = propStr;

PropertyValueInfo::SetCacheInfo(info, propStr, propStr->GetLdElemInlineCache(), false);
if ((attribs & PropertyWritable) == PropertyWritable)
if ((attribs & PropertyWritable) == PropertyWritable && type == typeToEnumerate)
PropertyValueInfo::Set(info, instance, index, attribs);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.