Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for MacOS #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed for MacOS #434

wants to merge 1 commit into from

Conversation

aaronjeline
Copy link

Mac OS sets macros for string functions and has _FORTIFY_SOURCE set to 2.

@sulekhark
Copy link
Contributor

Hi @aaronjeline, thank you for your work on this and for submitting this PR. It will be great if the following review comments are addressed:

  1. The comments on lines 54 thro' 61 need to be updated stating why the definitions are necessary in the macOS environment in spite of FORTIFY_SOURCE being greater than 0.
  2. The fix should be applicable only in the macOS environment when FORTIFY_SOURCE == 2. It should not change definitions in non-macOS environments when FORTIFY_SOURCE ==2.
  3. The same fix is also applicable to some definitions in stdio_checked.h.

@dtarditi
Copy link
Contributor

@aaronjeline, thanks for the changes! Could you address the pull request feedback so that we can commit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants