New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for signing DXIL post-compilation #1500

Open
gwihlidal opened this Issue Aug 14, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@gwihlidal

gwihlidal commented Aug 14, 2018

Is there an update on dxil validation in dxc, and allowing for validation/signing post-compile?

Right now you only get signed dxil if you happen to have dxil.dll in your compiler path, otherwise you just get unsigned dxil code.
https://github.com/Microsoft/DirectXShaderCompiler/blob/master/tools/clang/tools/dxcompiler/dxcutil.cpp#L143
https://blogs.msdn.microsoft.com/marcelolr/2018/03/06/using-the-github-dxcompiler-dll/

Post-compile would be nice to keep shader compile toolchains flexible on Windows, but also allow us to leverage dxc running on linux machines (i.e. cloud/cluster), and the results could signed on demand (or by some other Windows environment) prior to usage on a machine without experimental features enabled. This is a pretty huge request from us (we are doing tons of linux-based cloud scaling of our pipelines, etc.. which includes shader compilation).

A linux binary that supports signing/validation would be superior, but I understand if that needs to remain as-is. However, since the compiler itself is open source, and the dxil.dll binary is loaded during compilation, it seems reasonable allow this decoupling. This way unsigned dxil could be produced on linux or windows, and then some windows-based approach can ensure dxil is properly signed when appropriate.

@gwihlidal

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment