New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"onComputer" implementation of GesturePod #67

Merged
merged 13 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@ShishirPatil
Member

ShishirPatil commented Oct 31, 2018

No description provided.

Show resolved Hide resolved Applications/GesturePod/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
@metastableB

This comment has been minimized.

Contributor

metastableB commented Oct 31, 2018

@harsha-simhadri There are snippets of data being released with this PR. Please have a discussion with Shishir.

@metastableB

LGTM. Please have a look at data files.

GesturePod is a plug-and-play, gesture recognition device.
As the GesturePod involves hardware, this implements GesturePod's gesture recognition pipeline on your system. We have stored sensor data collected from the GesturePod. This pre-stored sensor data is used for gesture recognition. You can now play around with GesturePod on your system!

This comment has been minimized.

@harsha-simhadri

harsha-simhadri Oct 31, 2018

Collaborator

@ShishirPatil on your "system"? you mean PC or arduino?

This comment has been minimized.

@ShishirPatil

ShishirPatil Nov 1, 2018

Member

PC. Clarified in the latest commit.

@@ -0,0 +1,46 @@
GesturePod *(Gesture Recognition Pipeline)*

This comment has been minimized.

@harsha-simhadri

harsha-simhadri Oct 31, 2018

Collaborator

@ShishirPatil could you please check license info here

This comment has been minimized.

@ShishirPatil

ShishirPatil Nov 1, 2018

Member

We are not dependent on any external libraries for this directory. No code snippets used either. We have ownership on every line of code, for this directory.

```
./gesturepodsim
```
5. By default the program runs for data that has the following gesture: *Double Taps*.

This comment has been minimized.

@harsha-simhadri

harsha-simhadri Oct 31, 2018

Collaborator

@ShishirPatil So, this program is for taps or all gestures? The readme is confusing here. Why do you have a separate file for taps and a common data file?

This comment has been minimized.

@ShishirPatil

ShishirPatil Nov 1, 2018

Member

The program runs for the "gesture" contained in the data file present in ./data/ directory. Right now, the only gesture contained is Taps. Readme updated to reflect this, and articulate it better.

This comment has been minimized.

@metastableB

metastableB Nov 1, 2018

Contributor

You are assuming a lot of things here - a lot can go wrong. As far as I understand, the point of this code-isolation was to help people who want to understand/play-around with the gesture recognition pipeline. There is no need for us to support arbitrary number of data files. I think one data file is enough.

This comment has been minimized.

@ShishirPatil
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated
Show resolved Hide resolved Applications/GesturePod/onComputer/README.md Outdated

@harsha-simhadri harsha-simhadri merged commit 0faed7c into Microsoft:master Nov 7, 2018

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment