New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameRenderer hard-codes depth range to 0.2f to 1.0f ? #34

Closed
mtaulty opened this Issue Jun 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@mtaulty

mtaulty commented Jun 15, 2018

While running the StreamViewer sample on my HoloLens, I noticed that the 'far' depth stream didn't seem to be displaying anything other than nearby artefacts and this turned out to be because (AFAICT) FrameRenderer.cpp hard-codes the acceptable depth range to 0.2m to 1.0m whereas it seems like the 'long range' depth stream works beyond about the 0.8m range? I reworked mine to 0.2m to 4.0m and got better results for that stream so wondering why the sample doesn't allow that range and/or why it doesn't use the range values from the APIs themselves?

@polszta

This comment has been minimized.

Contributor

polszta commented Jun 17, 2018

I think have fixed this yesterday -- could you please give the latest a try?

Also, I'm not sure we're populating these ranges properly in the API just yet -- could you please file a product bug through Feedback Hub?

@mtaulty

This comment has been minimized.

mtaulty commented Jun 19, 2018

Great, thanks - yes, see the change and understand not using the API for the values if it's not reporting them correctly (or at all!).

@mtaulty mtaulty closed this Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment