Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable names are converted to uppercase in the container #32

Closed
vjgn opened this Issue Apr 18, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@vjgn
Copy link
Contributor

vjgn commented Apr 18, 2018

ServiceMonitor converts the environment variable names to upper case when adding to the app pool process.
Below line in IISConfigUtil.cpp seems to do a in place conversion of the environment name to upper case. FilterEnv(filter, CharUpper(pstrNameCheck), pstrValue)
This is causing environment variable replacement using ConfigBuilders to fail unless we change all AppSetting keys to be upper case which is not ideal.

@mcy94w

This comment has been minimized.

Copy link
Contributor

mcy94w commented Apr 18, 2018

I will make a fix in this week.

@vjgn

This comment has been minimized.

Copy link
Contributor Author

vjgn commented Apr 30, 2018

Any ETA on the fix. Thank you.

@mcy94w

This comment has been minimized.

Copy link
Contributor

mcy94w commented May 1, 2018

I have commented on your PR.
#33

@shirhatti

This comment has been minimized.

Copy link
Member

shirhatti commented Oct 22, 2018

Fixed in #33

@shirhatti shirhatti closed this Oct 22, 2018

@gislikonrad

This comment has been minimized.

Copy link

gislikonrad commented Mar 20, 2019

Any news on a release, or do I need to compile this myself?

I'm using the mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2016 container as a base image. According to the Dockerfile in the repo for that image, they are using v 2.0.1.6 of service monitor which is signed on october 5 2018. Is this fix supposed to be in that binary, because I'm still getting uppercase environment variables in the applicationhost.config.

@shirhatti

This comment has been minimized.

Copy link
Member

shirhatti commented Mar 23, 2019

@bariscaglar looks like this slipped through the cracks. Do you have someone who can take a look at releasing this?

@shirhatti

This comment has been minimized.

Copy link
Member

shirhatti commented Mar 23, 2019

Actually looks like I misspoke. 2.0.1.6 has this change in it already

@shirhatti

This comment has been minimized.

Copy link
Member

shirhatti commented Mar 23, 2019

Jumped the gun on that. Looked back on the build history. 2.0.1.6 was built from 5f6d967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.