Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default definition for GetColWiseData and GetColWiseData #5413

Merged
merged 3 commits into from Aug 16, 2022

Conversation

shiyu1994
Copy link
Collaborator

This is to fix the compilation warnings mentioned in #5176.

@jameslamb jameslamb added the fix label Aug 11, 2022
@jameslamb
Copy link
Collaborator

I've added the label fix. Please add a labels when you create pull requests here, so your PR will be correctly categorized in the release notes (#5403 (comment)).

@StrikerRUS
Copy link
Collaborator

MinGW cannot compile this

[100%] Linking CXX shared library C:\Users\runneradmin\AppData\Local\Temp\Rtmp67bvjP\Rbuildad07d9f1baf\lightgbm\src\lib_lightgbm.dll

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0x10): multiple definition of `LightGBM::DenseBin<unsigned char, false>::GetColWiseData(unsigned char*, bool*, std::vector<LightGBM::BinIterator*, std::allocator<LightGBM::BinIterator*> >*, int) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIhLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi[_ZNK8LightGBM8DenseBinIhLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0x30): multiple definition of `LightGBM::DenseBin<unsigned short, false>::GetColWiseData(unsigned char*, bool*, std::vector<LightGBM::BinIterator*, std::allocator<LightGBM::BinIterator*> >*, int) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinItLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi[_ZNK8LightGBM8DenseBinItLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0x50): multiple definition of `LightGBM::DenseBin<unsigned int, false>::GetColWiseData(unsigned char*, bool*, std::vector<LightGBM::BinIterator*, std::allocator<LightGBM::BinIterator*> >*, int) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIjLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi[_ZNK8LightGBM8DenseBinIjLb0EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0x70): multiple definition of `LightGBM::DenseBin<unsigned char, true>::GetColWiseData(unsigned char*, bool*, std::vector<LightGBM::BinIterator*, std::allocator<LightGBM::BinIterator*> >*, int) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIhLb1EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi[_ZNK8LightGBM8DenseBinIhLb1EE14GetColWiseDataEPhPbPSt6vectorIPNS_11BinIteratorESaIS6_EEi]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0x90): multiple definition of `LightGBM::DenseBin<unsigned char, false>::GetColWiseData(unsigned char*, bool*, LightGBM::BinIterator**) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIhLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE[_ZNK8LightGBM8DenseBinIhLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0xb0): multiple definition of `LightGBM::DenseBin<unsigned short, false>::GetColWiseData(unsigned char*, bool*, LightGBM::BinIterator**) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinItLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE[_ZNK8LightGBM8DenseBinItLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0xd0): multiple definition of `LightGBM::DenseBin<unsigned int, false>::GetColWiseData(unsigned char*, bool*, LightGBM::BinIterator**) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIjLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE[_ZNK8LightGBM8DenseBinIjLb0EE14GetColWiseDataEPhPbPPNS_11BinIteratorE]+0x0): first defined here

CMakeFiles\_lightgbm.dir/objects.a(dense_bin.cpp.obj):dense_bin.cpp:(.text+0xf0): multiple definition of `LightGBM::DenseBin<unsigned char, true>::GetColWiseData(unsigned char*, bool*, LightGBM::BinIterator**) const'

CMakeFiles\_lightgbm.dir/objects.a(bin.cpp.obj):bin.cpp:(.text$_ZNK8LightGBM8DenseBinIhLb1EE14GetColWiseDataEPhPbPPNS_11BinIteratorE[_ZNK8LightGBM8DenseBinIhLb1EE14GetColWiseDataEPhPbPPNS_11BinIteratorE]+0x0): first defined here

collect2.exe: error: ld returned 1 exit status

@shiyu1994 shiyu1994 merged commit 9489f87 into master Aug 16, 2022
@shiyu1994 shiyu1994 deleted the fix-5176 branch August 16, 2022 06:15
@shiyu1994
Copy link
Collaborator Author

The compilation warnings have been resolved.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants