Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoHandManipulatable script moves objects even if OneHandMovement option is unchecked #2021

Closed
Baxab opened this issue Apr 27, 2018 · 1 comment
Assignees
Projects

Comments

@Baxab
Copy link

Baxab commented Apr 27, 2018

Overview

I hope this is not a duplicate. I checked and it seems that nobody has reported this behaviour yet.
As you can get from the title, there is a bug in TwoHandManipulatable script. It's possible to move objects using one hand even if OneHandMovement option is unchecked.

Expected Behavior

While manipulating objects in one of TwoHand state (Scaling, Rotating, MovingScaling, RotatingScaling, MovingRotatingScaling), if I lose track of one of my hands I expect the action (move, scale, rotate) that I was doing to stop.

Actual Behavior

However, if I lose track of one of my hands the script automatically enters into the Moving state, allowing me to move the object I was manipulating with one hand.

How I solved it

Basically, I sorted out the problem by changing line 290 of TwoHandManipulatable script.
From:
newState = State.Moving;
To:
newState = State.Start;

Now everything seems to work as expected.

Unity Editor Version

Unity 2017.2.0f3

Mixed Reality Toolkit Release Version

2017.2.1.4 Patch Release

@david-c-kline david-c-kline added this to To do in 2017.4.0.0 via automation May 25, 2018
@david-c-kline david-c-kline added this to To do in 2017.4.1.0 via automation May 25, 2018
@david-c-kline david-c-kline removed this from To do in 2017.4.0.0 May 25, 2018
@keveleigh keveleigh assigned keveleigh and unassigned cre8ivepark Jul 18, 2018
@keveleigh keveleigh moved this from To do to In progress in 2017.4.1.0 Jul 18, 2018
@keveleigh keveleigh moved this from In progress to Done in 2017.4.1.0 Jul 19, 2018
@keveleigh
Copy link
Contributor

This should be fixed via #2459. Please take a look at the June branch to verify! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2017.4.1.0
  
Done
Development

No branches or pull requests

4 participants