This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add strong name for DotNetBridge #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jan 8, 2019
src/DotNetBridge/DotNetBridge.csproj
Outdated
| @@ -14,6 +14,8 @@ | |||
| <Copyright>(c) Microsoft Corporation. All rights reserved.</Copyright> | |||
| <RepositoryUrl>https://github.com/Microsoft/NimbusML</RepositoryUrl> | |||
| <PackageProjectUrl>https://github.com/Microsoft/NimbusML</PackageProjectUrl> | |||
| <SignAssembly>true</SignAssembly> | |||
| <AssemblyOriginatorKeyFile>tmsn.snk</AssemblyOriginatorKeyFile> | |||
There was a problem hiding this comment.
why is this named tmsn.snk? that seems cryptic
There was a problem hiding this comment.
Do you also want to set
<PublicSign Condition="'$(OS)' != 'Windows_NT'">true</PublicSign>
see
https://github.com/dotnet/machinelearning/blob/master/Directory.Build.props#L105
There was a problem hiding this comment.
I copied tmsn.snk from TLC to keep the keys the same for ML.NET external friend repos. I'll rename it to something less cryptic.
There was a problem hiding this comment.
It looks like the <PublicSign line is no longer necessary, since the bug was fixed - dotnet/roslyn#8210
montebhoover
approved these changes
Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow ML.NET assemblies to add DotNetBridge as InternalsVisibleTo friend.