Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample of using Q# code with F# driver #164

Merged
merged 5 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@tcNickolas
Copy link
Member

commented Apr 2, 2019

No description provided.

@tcNickolas tcNickolas requested review from cgranade and anpaz-msft Apr 2, 2019

@cgranade
Copy link
Member

left a comment

Thanks for doing this, @tcNickolas, it looks like a great start! My main concerns are in keeping Q# code to a uniform style going forward so that the experience is less surprising for users, so I've made comments to that effect. Thanks again!

Show resolved Hide resolved Samples/src/FSharpWithQSharp/FsharpDriver/FsharpDriver.fsproj Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/QuantumCode/Operations.qs Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/QuantumCode/Operations.qs Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/QuantumCode/Operations.qs Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/QuantumCode/Operations.qs Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md Outdated
Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md
Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md

cgranade and others added some commits Apr 3, 2019

Apply suggestions from code review
Co-Authored-By: tcNickolas <michaylova@gmail.com>
@cgranade
Copy link
Member

left a comment

Thanks! 💕

Show resolved Hide resolved Samples/src/FSharpWithQSharp/README.md Outdated
Update Samples/src/FSharpWithQSharp/README.md
Co-Authored-By: tcNickolas <michaylova@gmail.com>

@tcNickolas tcNickolas merged commit cedac28 into master Apr 3, 2019

2 checks passed

Microsoft.Quantum #0.0.1904.307 succeeded
Details
license/cla All CLA requirements met.
Details

@tcNickolas tcNickolas deleted the mariia/fsharp-sample branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.