Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Split build and tests script in AppVeyor #1372

Merged
merged 9 commits into from Jan 23, 2019
Merged

[CI] Split build and tests script in AppVeyor #1372

merged 9 commits into from Jan 23, 2019

Conversation

JuanAr
Copy link
Contributor

@JuanAr JuanAr commented Jan 21, 2019

Description

We applied the feedback of the PR #1351

  • Split .Net, Java and JavaScript build script and tests script
  • Add custom error messages for each build and test(except for Java and Javascript tests which are not supported by the current process)
  • Add a label for each process for easier reading of the log

Passing Tests

Before
image

After
image

Label Example
image

tellarin
tellarin reviewed Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the existing build.cmd scripts now internally call the new buid/test ones to keep consistency?

@ParadoxARG
Copy link
Contributor

Sure! We'll update the build.cmd script to run both build.ci.cmd and tests.ci.cmd scripts.

@ParadoxARG ParadoxARG force-pushed the feature/appveyor/split-build-tests branch from 09c0347 to 3194104 Compare January 22, 2019 19:29
@ParadoxARG
Copy link
Contributor

@tellarin Rebased and feedback applied!

@tellarin tellarin merged commit 80fb95c into microsoft:master Jan 23, 2019
@JuanAr JuanAr deleted the feature/appveyor/split-build-tests branch January 23, 2019 16:40
iMicknl added a commit to iMicknl/Recognizers-Text that referenced this pull request Feb 18, 2019
@iMicknl
Squashed commit of the following:
40ab212 
commit 63cb0753740657f29144246c0613f299ef163247
Author: Denise Scollo <dens.scollo@gmail.com>
Date:   Thu Feb 14 04:52:16 2019 -0300

    [StyleCop] Fix all remaining warnings in all C# projects  (#1458)

    * [StyleCop] Fix all warnings left
    - Reorder methods
    - Reorder usings
    - Create new files for classes
    - Reorder usings
    - Fix encoding

commit 10fbe23e6b96fb0a6185e39ecce55fe45804e54d
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Wed Feb 13 23:18:26 2019 -0800

    [NL .NET] Improve first version of DateTimeV2 model (#1443)

    * Translate missing keys and update DateParser

    * Remove duplicate case

    * Update translations

    * Update patterns+ cases

    * Fix 2 more cases

commit b3b569934282522e2cfa6850866705da5d461b6b
Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com>
Date:   Thu Feb 14 11:49:51 2019 +0800

    Fill in the blank of RestOfDateTimeRegex and add a new Unit "jornada" (#1453)

commit 537c2ba282e3f3d4ea235ca1962cd458e5d6f092
Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com>
Date:   Thu Feb 14 11:29:11 2019 +0800

    fix "Ocurrirá 1/1/2015 entre las 10 h y las 11.30 h" and "Ocurrirá desde las 10.30 h hasta las 15 h de 1/1/15" (#1456)

commit 0e5e528179f53e8e7180dc3d4da90d31e783abd4
Author: ya liu <401619741@qq.com>
Date:   Thu Feb 14 11:27:11 2019 +0800

    Fix spanish dateperiod cases (#1457)

    * Fix spanish dateperiod cases

    * Fix Spanish dateperiod test cases

    * Fix Regex about Spanish DatePeriod

commit 3b96774e655dd0cee2a73b2759ef02fc5d3acf81
Author: ya liu <401619741@qq.com>
Date:   Wed Feb 13 13:55:56 2019 +0800

    Fix Spanish dateperiod cases (#1454)

    * Fix spanish dateperiod cases

    * Fix Spanish dateperiod test cases

commit 36eab27b5bf852a5427453f13a9da0957e7e4b05
Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com>
Date:   Wed Feb 13 13:50:49 2019 +0800

    Fix TimeUnitRegex and RelativeTimeUnitRegex (#1455)

commit 1e1cae980ff8cdbd5e10a86276e117a650c5bda8
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Feb 12 05:01:47 2019 -0300

    [dotnet] Remove unused code from MergedDateTimeParser (#1450)

    * Update Japanese MergeDateTimeParser
    - Remove unused if statement

    * Update Japanese MergeDateTimeParser
    - Remove unused if statement

commit 6b1812da403aed1ef618900bb4fcf004883416e4
Author: Denise Scollo <dens.scollo@gmail.com>
Date:   Tue Feb 12 05:01:08 2019 -0300

    [StyleCop] Fix all the warnings in Dutch Parsers (#1446)

    - Reorder fields, properties, methods and constructors
    - Add and remove spaces when needed
    - Remove unnecessary parenthesis
    - Reorder using statements

commit 1136dc2af54ca4b4659a78fa27577297feb41c2e
Author: Denise Scollo <dens.scollo@gmail.com>
Date:   Tue Feb 12 04:59:12 2019 -0300

    [StyleCop] Fix all the warnings in Dutch Extractors (#1445)

    - Reorder fields, properties, methods and constructors
    - Add and remove spaces when needed
    - Remove unnecessary parenthesis

commit e5f079254d3943cadf14ddb9b2d16a839ed5f8af
Author: Denise Scollo <dens.scollo@gmail.com>
Date:   Tue Feb 12 04:57:25 2019 -0300

    [StyleCop]Fix all the remaining warnings in Number Project (#1444)

    - Rename local variable
    - Reorder methods
    - Remove regions
    - Add spacing

commit 4af1e01e47d222326ecea7e79ae045c1c452031d
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Feb 12 04:56:17 2019 -0300

    [StyleCop] Fix new warnings in Test TestHelpers (#1396)

    * [StyleCop] Fix new warnings in Test TestHelpers
    - Add files for classes: RecognizerExtensions, TestModelExtensions, TestResources, TestResourcesExtensions, TestUtils
    - Add ruleset to the project
    - Document enums
    - Add trailing comma
    - Add and remove spacing when needed

    * Fixed spacing in RecognizerExtensions file

    * Fixed remaining warnings in files.

    - Replaced "" for string.Empty in TestUtils

commit 3bd0226e8ff6e28a8e0a1ad661c820ea01270b59
Author: ya liu <401619741@qq.com>
Date:   Tue Feb 12 15:54:36 2019 +0800

    Fix spanish dateperiod cases (#1449)

commit 215f2af656a3c90869c53a4498c1f1ce0ab07ee9
Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com>
Date:   Tue Feb 12 15:53:30 2019 +0800

    fix a test spec. "de" means "from" here. (#1448)

commit deaf3ce0748c51f3c9e068295a3f36864271a663
Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com>
Date:   Tue Feb 12 15:51:52 2019 +0800

    fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" (#1451)

    * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" by adding "h" in AtRegex and

    * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" iteration 2. Modify the comments

commit bfdd32440ef033c969839332d8be75162d1b241a
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Sat Feb 2 16:02:17 2019 +0800

    Removing unnecessary properties from SimpleConsole project. (#1441)

commit a063aaa3c414ab0c6a8624bc8c51ddcf3a25a081
Author: Mu Guo <guom08@gmail.com>
Date:   Sat Feb 2 15:21:38 2019 +0800

    Correct behaviour for "upcoming/past + weekday" (#1437)

    * Extend behaviour

    * Rename and reorganize regexes

    * Adjust the behavior of "following + weekday"

commit 58f040c96d39b78904c50426cade3a5bf5c3739f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sat Feb 2 03:01:42 2019 -0300

    [DotNet][DateTime] Fix extractors and parsers name in Japanese and Chinese languages (#1431)

    * Fix extractors and parsers class name in Chinese language

    * Fix extractors and parsers class name in Japanese language

commit 0b2a0be00bc9ebd488e308f7e7b7e62a2f59fd5e
Author: Mu Guo <guom08@gmail.com>
Date:   Sat Feb 2 13:59:07 2019 +0800

    Support combination of modifiers (#1439)

    * Enable combination of modifiers

    * Fix the parsing of "modifier + daterange"

commit 051eb9cd089bae78a0fb9d4f4330338634497b17
Author: Mu Guo <guom08@gmail.com>
Date:   Sat Feb 2 12:25:08 2019 +0800

    Filter out the wrong extraction for "may differ" (#1435)

    * Filter out "may differ" and update resources

commit 3792a99fad7710f3f90714affcb83dc60aabb4dc
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sat Feb 2 04:56:46 2019 +0100

    [.NET DateTime] Enable NL DateParser tests + remove 2 tests (#1440)

    * Enable DateParser + remove 2 tests

    * Mark 2 cases as NotSupported for now

    * Remove duplicate case

commit 050d1d09f3db67a543b75728af20ae37916b3b69
Author: ya liu <401619741@qq.com>
Date:   Sat Feb 2 09:20:41 2019 +0800

    Fix Spanish DatePeriod cases (#1438)

    * Fix Spanish DatePeriod cases

    * fix Spanish DatePeriod case and modify the error cases to right answer

commit 938c9b907497407bbf987c88c18524ec4b6526b3
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 29 23:30:39 2019 -0300

    Refactor nested if-else, changed to a switch-case (#1433)

commit 90d258d4cea044d47ed10994b82fcaba8a2f1b19
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 29 23:29:31 2019 -0300

    Fix IDateTimeExtractor type to IDateExtractor in English and Spanish languages (#1432)

commit 5ee2f3840cf4f0d0a006faa571282c0020359055
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Wed Jan 30 09:51:55 2019 +0800

    Support WeekDayAndDay in DateTime model (#1416)

    * Support WeekDayAndDay, e.g., Monday 21

    * Add a few comments and minor fix

    * Fixes according to the comments

commit c11cde1050952486dcf60c381616721e92c3aae2
Author: Jin Wang <810256009@qq.com>
Date:   Tue Jan 29 19:41:29 2019 +0800

    Support case “next” (#1400)

    * Support relative references like "last", "next one",  "previous one"

    * Add specs

    * Regen python.

    * Regen JavaScript.

    * Support relative references like "last", "next one", "previous one"

    * Support "the second to last", "the one before the last one", etc.

    * Add base class.

    * Revise base class.

    * Support case "next".

    * Optimize the regex .

    * Add a EnablePreview option.

    * Fix bug.

    * Fix a bug.

commit 935d186926e0bedb99c1c77054277a1cead1a955
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Jan 28 21:30:06 2019 -0300

    [DotNet][DateTime] Rename YearAfterRegex as DateAfterRegex (#1417)

    * Renamed YearAfterRegex to DateAfterRegex.

    * Include of the modified DateTimeDefinitions files

commit d892e384f23354039559e4bbe53758c78cee3dac
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Jan 28 00:44:05 2019 -0300

    Move EnglishDatetimeUtilityConfiguration class to utilities folder (#1423)

commit 78cc3819e530120717894f09a67f9697b915cf37
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Jan 28 00:43:41 2019 -0300

    [Java] Rename DinoComparer to StringComparer and update implementation (#1422)

    * Refactor DinoComparer
    - Change name to StringComparer
    - Polish implementation to make it more expressive

commit df9496076c9f5ba95d9c421611b77ec3c6111934
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Jan 28 00:42:08 2019 -0300

    [StyleCop]  Add warning fixes generating Breaking Changes  (#1420)

    * Fix all StyleCop's warnings in TextMatchers files

    - Reorder properties, fields and methods
    - Remove trailing whitespace
    - Add trailing comma
    - Reformat setters and getters

    * Fix all the StyleCop warnings in Parsers

    Files:
        -BaseMergedUnitParser.cs
        -INumberWithUnitParserConfiguration.cs
    Warnings:
        -SA1400	Class should declare an access modifier
        -SA1401	Field should be private
        -SA1122	Use string.Empty for empty strings

    * Fix all the StyleCop warnings in NumberWithUnitParser

    Warnings:
        -SA1401	 Field should be private
        -SA1122	 Use string.Empty for empty strings
        -SA1124	Do not use regions
        -Add file with the class UnitValue

commit 78c6b58966f783447cf54370b1067b98fef9e0de
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Jan 28 00:41:08 2019 -0300

    [StyleCop] Fix warnings in Text.Number Project (#1419)

    * Fix StyleCop warnings in SpanishNumberRangeParserConfiguration
    -Move constructor before properties
    -Move constructor initializers on their own line
    -Add class access modifier

    * Fix StyleCop warnings in Text.Number project
    -XML comment analysis warning

    * Fix StyleCop warning in NumberMode
    -Update comment to fix CS1570 XML comment on 'variable' has badly formed

    * Fix StyleCop warnings in BasePercentageExtractor
    -Reorder properties an fields
    -Set field to property to keep the variable name with upper-case
    -Add retuns comments in methods
    -Add trailing coma in multi-line initializers
    -Use String.Empty instead empty strings

commit 8659d6eb71d9b38937b23cfbe8651fc593b25c29
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Jan 28 00:38:50 2019 -0300

    Fixed rangeConnectorRegex Pattern to public static (#1418)

commit eb01e593a0b26ad8d41780a4a18c77cab3fba628
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Jan 28 00:37:10 2019 -0300

    [CI][DotNet] Add Code Analysis as part of build process (#1405)

    * Update install FxCopAnalyzers NuGet package in all projects of the solution

    * Add code analysis rules in the Recognizers-Text.ruleset

    * Add rule CA1021 (avoid out parameters) to Code Analysis ruleset

commit 444251627e01205b877fc1bd556ebb11f287f359
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Jan 28 00:36:15 2019 -0300

    [JavaScript] Rename DinoComparer to StringComparer and update implementation  (#1404)

    * Rename DinoComparer to StringComparer and update implementation

commit e0c9867ca975676dfc726c1666d7406bec07bc69
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Thu Jan 24 23:38:37 2019 -0300

     [StyleCop] Fix all the warnings in Definitions  (#1409)

    * Fix StyleCop warnings in Definition csproj
     -Add rulset reference

    * Fix StyleCop's warnings in AssemblyInfo.
    - Added header to the file

    * Fix all the warnings in DefinitionLoader
    - Fixed spacing

commit f9272ffc06cf2479dab408c7c13c3f2bedc93368
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 23:24:59 2019 -0300

    [StyleCop] Fix warnings in English and German TimeParser (#1411)

    * Fix StyleCop warnings in EnglishTimeParser
    -move constructor initializers on their own line

    * Fix StyleCop warnings in GermanTimeParser
    -move constructor initializers on their own line

commit e3a7b4f0ec880224ce3d3cebc1d7c36e08c738db
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 23:24:39 2019 -0300

    [StyleCop] Fix all the warnings in AssemblyInfo (#1412)

    - Remove trailing whitespace

commit d1115171e62878d9f88684c503161adc92c07118
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 23:24:18 2019 -0300

    Renamed variable for clarity in BaseDateParser (#1410)

commit acd432384c5fd15924d75709308c21d73f4e2047
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Thu Jan 24 23:19:51 2019 -0300

    Refactor DinoComparer to StringComparer (#1406)

    - Change DinoComparer to StringComparer for more clarity, refactored it's method for a better implementation
    - Fix NumberWithUnitExtractor to make it work with the new comparer

commit ec195092f2b943ef930193027781dbc653141a81
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Thu Jan 24 23:17:51 2019 -0300

    - Import and update the methods from `DateTimeFormatUtil` to `FormatUtil` class keeping them with the proper implementation. (#1403)

    - Remove duplicated `DateTimeFormatUtil` class
    - Refactor `FormatUtil` class name to `DateTimeFormatUtil` to keep the same pattern used in other languages

commit 2ba1ab6d6dab8b4ab0059b025dfd11beba6ddcb0
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 23:16:55 2019 -0300

    Renamed regex variable 'AndRegex' to match used regex 'RangeConnectorRegex' (#1402)

commit bea4527b276ace54ff3027987ac0170c5caf7f9e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 23:16:11 2019 -0300

    [DotNet][DateTime] Refactor GetModAndDate method since it has too many parameters (#1401)

    * Refactor BaseDatePeriodParser - GetModAndDate method since it has too many out/ref parameters

    - Created new class GetModAndDateResult containing the properties we need to return in the method GetModAndDate
    - Redesigned GetModAndDate method to remove the out/ref parameters and return an instance of a GetModAndDateResult object.

    * Renamed class 'GetModAndDateResult' to 'ModAndDateResult'

commit 3da09064140132cd322534990c63a77fd51aa678
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Jan 24 16:06:34 2019 +0800

    Fix for cases like 'that one mile' being wrongly resolved to the null value (#1398)

    * Fix for cases like 'that one mile' being wrongly resolved to the null value.

    * Add specs in DateTimeModel and DateTimeModelComplexCalendar

commit c5476597b79548a3cd4f6e19e18531ca698e6926
Author: Jin Wang <810256009@qq.com>
Date:   Thu Jan 24 16:05:57 2019 +0800

     Support relative references like "last", "next one", "previous one" (#1268)

    * Support relative references like "last", "next one",  "previous one"

    * Add specs

    * Regen python.

    * Regen JavaScript.

    * Support relative references like "last", "next one", "previous one"

    * Support "the second to last", "the one before the last one", etc.

    * Add base class.

    * Revise base class.

commit 14a94eba48d29cf9e4b39c50679c2c7e1a5acee6
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Thu Jan 24 15:11:06 2019 +0800

    Fix build break after timezone optimization changes made Dutch out of sync (#1397)

    * - Fix build break after timezone optimization changes made Dutch out of sync;
    - Minor refactoring to reuse new timezone match loader;
    - Removed most non-localized string in Dutch TimeZone YAML. Re-use needs to be improved later;
    - Small stylecop fixes in Dutch.

    * Fixing stylecop warnings:
    - Remove trailing spaces;
    - Spacing within {} declarations;
    - Blank line before single-line comment;
    - Sort usings;
    - Comma on multi-line init.

    * Fixing more simple stylecop issues.

    * Trying to fix NETSDK1061 by following https://docs.microsoft.com/en-us/dotnet/core/deploying/runtime-patch-selection

commit 091a553a0f482794cd17d6ba210a19e81edd5796
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 01:01:20 2019 -0300

    [DateTime] Refactor StringExtension 'Normalized' method (#1394)

    * Add Spanish special characters YAML

    * Add Portuguese special characters dictionary to YAML

    * Create StringExtension with the Normalized method as an extension

    * Update Spanish parsers to use the new String utility

    * Update Portuguese parsers to use the new String utility

    * Update Java using YAML files

    * Port StringExtension to Java

    * Configure SpanishDateParserConfiguration to start using StringExtension

commit ad757a4e0c29b79a69f3368c3a27bdbfb65dc85b
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Thu Jan 24 04:59:27 2019 +0100

    [NL DateTime] Initial support of Dutch DateTimeModel in .NET  (#1102)

    * Initial commit of new DateTime implementation

    * Activate recognizer + add new definitions

    * Update Microsoft.Recognizers.Text.DataDrivenTests.csproj

    * Update definitions for 10e & vandaag

    * Translate hardcoded strings to Dutch

    * Update & reorder Holiday definitions

    * Fix 'op de 15e'

    * Add support for - and . notation in dates

    * Fix 'aanstaande' & 'laatste' + weekday

    * Fix 'vijf april' case

    * Change Prinsjesdag to the right value

    * Add more holiday patterns

    * Change to DutchVeteransDay date

    * Fix 'dit jaar'

    * Move definitions to new folder

    * Add missing TimeZones reference

commit 24c1b0d5838c9b47fa9adc98cd6ea666e6fa2ab1
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Thu Jan 24 00:44:09 2019 -0300

    Update Java SpanishTimeParserConfiguration to C# (#1389)

commit 41ebc1d4e47e4189c50b7f31ed1ae254d4081c42
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Thu Jan 24 00:42:36 2019 -0300

    [StyleCop] Fix all the warnings in Metadata (#1393)

    - Add setters and getters to the fields
    - Remove spacing

commit 26345c44878f2c77db50c207f6b7f08fb1cd8a1a
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 00:41:34 2019 -0300

    [StyleCop] Fix all warnings in DateTime (#1392)

    * Fix StyleCop warnings DateTimeFormatUtil
    -Rename file to match with the class name

    * Fix StyleCop warnings in Portugese/DateTimePeriodParser
    -Set parameters across multiple lines
    -Move constructor initializers on their own line
    -Reorder using statement

    * [StyleCop] Fix all the warnings in DateTime
    - Add trailing comma
    - Remove trailing whitespace
    - Put constructor initializer on it's own line
    - Remove and add spacing when needed

    * Fix all StyleCop warnings in Base Parser and Extractor files.

    - Fixed spacing and trailing commas.
    - Reordered methods.
    - Fixed encoding in AbstractYearExtractor file.

    * Fix StyleCop warnings in DateTimeOptions -Add enum documentation

commit b034148f60fe2bbcae46ae93e11b704da1cf06fd
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 00:40:32 2019 -0300

    Fix StyleCop warnings in DictionaryUtils (#1391)

    -Braces should not be omitted
    -Set parameters across multiple lines

commit a2edbcd7f5d54b484eb3612eb7cdd4b6bdbd2c5e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 00:39:49 2019 -0300

    [Stylecop] Fix warnings in Test.Sequence project (#1390)

    * Fix StyleCop warnings in GUIDParser.cs
    -Fix parameter name to begin with lower-case

    * Fix StyleCop warnings in IpParser.cs
    -Remove trailing whitespace

    * Fix StyleCop in SecuenceOption
    -Add enum documentation

commit 585538b033b007bf52193208076078a6da723b82
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 24 00:38:59 2019 -0300

    [StyleCop] Fix StyleCop warnings in IDateParser (#1377)

    *  Fix all the StyleCop warnings in IDateTimeParser
    -Add spaces to comments
    -Change "" to string.Empty
    -Add the file TimeTypeConstants with the class TimeTypeConstants
    -Add rule to ignore the underscore in the TimeTypeConstants variables names

    * Move TimeTypeConstants from /Parsers to project root directory

commit a7d50b7a24aa806ea34160fda4037d7c35a86ae6
Author: Jin Wang <810256009@qq.com>
Date:   Thu Jan 24 11:38:01 2019 +0800

    Support normalized query. (#1388)

commit 41bbee93546cbda2548f386a5d5c794e23721472
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Wed Jan 23 13:59:16 2019 +0800

    Improve the performance of LocationTimeZoneMatcher by pre-check (#1387)

    * Improve the performance of LocationTimeZoneMatcher by pre-check

    * Port this refactor to Java.

commit c33d0645d3c20ec4e33f09ff71cd9549e6e6b21c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Wed Jan 23 00:28:08 2019 -0300

    [StyleCop] Fix all warnings in HolidayExtractorChs (#1376)

    * Fix StyleCop all warnings in HolidayExtractorChs

    - Renamed file to 'ChineseHolidayExtractorConfiguration' to match class name.
    - Fixed spacing.
    - Reordered methods and properties.

commit f85fbc7c40dd765bc133d57ff11bd75b9b1d5f75
Author: JuanAr <juan.arguello@southworks.com>
Date:   Wed Jan 23 00:16:59 2019 -0300

    Fix StyleCop warnings in JapaneseHolidayParser (#1385)

    -Remove trailing whitespace
    -Remove region comment
    -Add space between opening and closing braces
    -Add trailing coma in multi-line initializers
    -Use String.Empty instead empty strings
    -Add space beteween methods

commit 666e938c37993163a56ff1e0e5bad60eccdfa539
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Wed Jan 23 00:07:16 2019 -0300

    [StyleCop] Fix all the warnings in BaseDatePeriodParser (#1384)

    * - Reorder usings and methods
    - Add parentheses
    - Add trailing comma
    - Remove trailing whitespace
    - Adjust spacing

commit 2541d5272e07c6f8ae02afce47937fc9f4f573f0
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 23:55:31 2019 -0300

    Fix StyleCop warnings in Japanese DatePeriodParser (#1383)

    -Add trailing coma in multi-line initializers
    -Use String.Empty instead empty strings
    -Add whitespace before * operator
    -Remove trailing whitespace

commit c1440f827b5e2b97c392ba236ea5978118ab32ca
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 23:49:39 2019 -0300

    [StyleCop] Fix warnings in Italian, French and German DateParserConfiguration (#1378)

    * Fix StyleCop warnings in ItalianDateParserConfiguration
    -Move constructor before properties
    -Remove extra parentesis
    -Add space after closing brace

    * Fix StyleCop warnings in FrenchDateParserConfiguration
    -Move constructor before properties
    -Remove extra parentesis
    -Add space after closing brace

    * Fix StyleCop warnings in GermanDateParserConfiguration
    -Move constructor before properties

commit 9e979a073ff25ab1028ad9d8b7952c16d9713e80
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 23:35:25 2019 -0300

    [StyleCop] Fix warning Spanish and German Configuration files (#1381)

    * Fix StyleCop warnings in GermanHolidayParserConfiguration
    -Use String.Empty instead empty strings
    -move constructor initializers on their own line

    * Fix StyleCop warnings in GermanTimePeriodParserConfiguration
    -Move constructor before properties
    -Use String.Empty instead empty strings

    * Fix StyleCop warnings in GermanDatetimeUtilityConfiguration
    -move parameters to begin on the same line of the declaration

    * Fix StyleCop warnings in SpanishSetParserConfiguration
    -Move constructor before properties

commit ca27f7b2a6f2b79a5d9f5ac24dd2dd9e3710497a
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Jan 22 22:57:46 2019 -0300

    [StyleCop] Fix warnings in English and German TimeParser (#1382)

    * Fix StyleCop warnings in EnglishTimeParser
    -move constructor initializers on their own line

    * Fix StyleCop warnings in GermanTimeParser
    -move constructor initializers on their own line

commit 35daedaaf43469201be16349cd4944e14602d7bd
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Jan 22 22:54:52 2019 -0300

    Fix all warnings in Japanese SetExtractor file (#1380)

    - Fixed spacing.

commit 1e0dd81d5aa731695e8f7bee2b63e6a2bad8ad30
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 22:53:32 2019 -0300

    [StyleCop] Fix warnings in Spanish and Portuguese DateParserConfiguration (#1379)

    * Fix StyleCop warnings in SpanishDateParserConfiguration
    -Move constructor before properties
    -Suppressed warning message because the method StringExtension will be refactored.

    * Fix StyleCop warnings in PortugueseDateParserConfiguration
    -Move constructor before properties
    -Suppressed warning message because the method StringExtension will be refactored.

commit ad87a976f55aaea6a5b5de62706e6a169b06de44
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Jan 23 09:39:15 2019 +0800

    Simple stylecop fixes in .NET (#1386)

commit 95d84441b1467dc7ec73d78d84f4468a3e9a83eb
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 21:35:49 2019 -0300

    [StyleCop] Fix BaseDateExtractor StyleCop Warnings (#1375)

    * Fix BaseDateExtractor StyleCop Warnings

    * Fix Stylecop warnings in BaseDateExtractor
    -Remove trailing whitespace
    -Reorder using statement
    -Rename variable with Hungarian notation
    -Reorder methods

commit fdbae9e52cdd186931f7ea69fbb0df15bb7fbba0
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 21:31:59 2019 -0300

    [StyleCop] Fix all warnings in the NumberWithUnit basic files (#1374)

    * Fix all the StyleCop warnings in NumberWithUnitRecognizer

    Warnings:
    - SA1009	Closing parenthesis should not be followed by a space
    - SA1012	Opening brace should be followed by a space.
    - SA1413	Use trailing comma in multi-line initializers
    - SA1202	'protected' members should come before 'private' members

    * Fix all the StyleCop warnings in CurrencyUnitValue

    * Fix all the StyleCop warnings in Parsers
    Files:
        -BaseMergedUnitParser.cs
        -INumberWithUnitParserConfiguration.cs
    Warnings:
        -SA1400	Class should declare an access modifier
        -SA1401	Field should be private
        -SA1122	Use string.Empty for empty strings

    * Fix StyleCop warnings in Constants file.

    * Fix all the StyleCop warnings in NumberWithUnitParser

    Warnings:
        -SA1401	 Field should be private
        -SA1122	 Use string.Empty for empty strings
        -SA1124	Do not use regions
        -Add file with the class UnitValue

    * Fix StyleCop warnings in NumberWithUnitOptions

    - Add emun documentation

    * Change config to Config

    * Apply feedback from PR

commit 80fb95c413e011ec4bc6a603cb9fef62c429ee79
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 21:29:32 2019 -0300

    [CI] Split build and tests script in AppVeyor (#1372)

    * Split .Net build and tests scripts

    * Split Java build and tests scripts

    * Split JavaScript build and tests scripts

    * Split Python build and tests scripts

    * Update AppVeyor to use new build and tests scripts

    * Update .Net build.cmd to execute build.ci.cmd and tests.ci.cmd

    * Update Java build.cmd to execute build.ci.cmd and tests.ci.cmd

    * Update JavaScript build.cmd to execute build.ci.cmd and tests.ci.cmd

    * Update Python build.cmd to execute build.ci.cmd

commit 5b3703192d5338f33c2f8e70b4b503c02b18de66
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 21:26:16 2019 -0300

    [Java][DateTime] Port Base Parsers latest changes in C# (#1373)

    * Update BaseDateperiodParser

    * Update BaseDateTimeParser

    * Update BaseDateTimePeriodParser

    * Update BaseHolidayParser

    * Update BaseMergedDateTimeParser

    * Update BaseSetParser

    * Update BaseTimeParser

    * Update BaseTimePeriodParser

commit eddf833b90e43fefd7d9e5fd7043cd2e5b23e45e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 08:41:38 2019 -0300

    [StyleCop] Fix all warnings in DateTime files (#1368)

    * Fix StyleCop warnings in TimeZoneUtility

    * Fix StyleCop warnings in TimexUtility

    * Fix all StyleCop warnings in EnglishTimeZoneExtractorConfiguration

    * Fix all StyleCop warnings in GermanHolidayExtractorConfiguration

    * Fix StyleCop warnings in BaseDateTimeParser

    * Fix StyleCop warnings in BaseTimeZoneParser

    * Fix all StyleCop warnings in DateExtractor class -Fixed comments spacing -Added trailing commas

    * Fix StyleCop warnings in DateExtractor

    * Fix all StyleCop warnings in SpanishHolidayExtractorConfiguration

    - Added spaces when needed

    * Fix all StyleCop warnings in PortugueseDateTimeUtilityConfiguration

    - Deleted unnecesary spaces
    - Added newlines when needed

    * Fix all StyleCop warnings in PortugueseCommonDateTimeParserConfiguration

    - Addded spaces when needed

commit d84c27234c9473a4ca735e831fcff802a32c9955
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 04:29:00 2019 -0300

    Fix StyleCop warnings in DataDrivenTest\Number (#1371)

    -TestDecimalAndThousandsSeparators
    -LongFormTestConfiguration
    -TestNumberRecognizerCache
    -TestNumberRecognizerInitialization
    -TestParserFactory
    -TestNumber_Portuguese
    -TestNumber_Spanish
    -TestNumber_Korean
    -TestNumber_Japanese
    -TestNumber_Italian
    -TestNumber_German
    -TestNumber_French
    -TestNumber_English
    -TestNumber_Dutch
    -TestNumber_Chinese

commit 65847751d305aa1c914dae70bbf32e410578528a
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 04:27:47 2019 -0300

    [StyleCop] Fix all warnings in the Sequence tests (#1370)

    - Reorder usings
    - Change base to this

commit 668a63c5ef74d4046b3ccfa55599a55455eba04a
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 04:27:26 2019 -0300

    [StyleCop] Fix all warnings in Japanese HolidayExtractorConfiguration (#1369)

    * Update file name to match with the class name

    * Fix StyleCop warnings in JapaneseHolidayExtractorConfiguration
    - Add trailing comma in multi-line initializers
    - Reorder the class constructor

commit e443b703a38b00b7309abd77dee7cd65cfccb180
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 04:25:08 2019 -0300

    [StyleCop] Fix all the warnings in ChoiceConfig (#1348)

    * Fix StyleCop warnings in
    -ChoiceRecognizer
    -Constants
    -BooleanParserConfiguration

    * Fix all StyleCop warnings in ChoiseOption file.
    - Added enum comments.

commit e3be45a724c9e6daa8c9bacab4da0f583f220eac
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Tue Jan 22 15:24:00 2019 +0800

    Improve the performance of TimeZone: replacing regexes with StringMat… (#1352)

    * Improve the performance of TimeZone: replacing regexes with StringMatcher

    * Port new behaviour with StringMatcher to Java

commit 5ce7cb3b0ab49566c2ff85b017c7099eb3bd5ff5
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 22 04:23:13 2019 -0300

    Fix the warning generated on the CSC file in every project and add the autogenerated .xml files (#1367)

commit 0d9465176d9d97c8604118893f56088fb293e7f5
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Mon Jan 21 02:31:44 2019 -0300

     [DateTime] Fix DateTimePeriodExtractor test (#1353)

    * Fix "Hoy estaré fuera de cinco a siete" test results

    * Fix .Net "Input": "Hoy estaré fuera de cinco a siete" test

commit ac87e81441bed5ef288275dae1419c1ce33939df
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:37:57 2019 -0300

    [StyleCop] Fix warnings in DataDrivenTest/NumberWithUnit (#1365)

    * Add stylecop reference to csproj

    * Fix all the StyleCop warnings in NumbersWithUnits
    - Change base for this
    - Reorder using statements
    - Add trailing comma

commit 9ed71ce1dbbe6bd1927c3d6eda672b1c5ffeb65c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:36:00 2019 -0300

    [StyleCop] Fix all the warnings in DataType.Tests (#1364)

    * Add stylecop reference to csproj

    * Fix all stylecop warnings for the DataTypes.DataDrivenTests

commit e5a5e25f8f805a38489eaa1bc06394a1229f8e44
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:29:22 2019 -0300

    Fix all StyleCop warnings in Chinese Parser files. (#1363)

    - Fixed spacing.
    - Reordered using statements.

commit 1151d6f4a32a85321ec0cf6fdb05e086555e201f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:28:57 2019 -0300

    Fix all StyleCop warnings in Dutch Extractor files. (#1362)

    - Fixed spacing.
    - Reordered files, properties and methods.

commit bee20517ae0b2de375f09be9cfebcfce1f2dc79d
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:27:37 2019 -0300

    Fix all StyleCop warnings in Dutch Parser files. (#1361)

    - Fixed spacing.
    - Reordered using statements.

commit 3f528069bf59ce973d9c7526cce721335a74d3ee
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:06:20 2019 -0300

    Fix StyleCop warnings in (#1360)

    - WeightExtractorConfiguration
    - VolumeExtractorConfiguration
    - TemperatureExtractorConfiguration
    - SpeedExtractorConfiguration
    - EnglishNumberWithUnitExtractorConfiguration
    - LengthExtractorConfiguration
    - DimensionExtractorConfiguration
    - CurrencyExtractorConfiguration
    - AreaExtractorConfiguration
    - AgeExtractorConfiguration

commit d5d3dcd58b87b350e4438f6ef3891cf8d873235c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:04:52 2019 -0300

     Fix all the StyleCop warnings in German Extractors (#1359)

    Files:
        -AgeExtractorConfiguration.cs
        -AreaExtractorConfiguration.cs
        -CurrencyExtractorConfiguration.cs
        -DimensionExtractorConfiguration.cs
        -GermanNumberWithUnitExtractorConfiguration.cs
        -LengthExtractorConfiguration.cs
        -SpeedExtractorConfiguration.cs
        -TemperatureExtractorConfiguration.cs
        -VolumeExtractorConfiguration.cs
        -WeightExtractorConfiguration.cs
    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

commit a323d50eae3279285c3cbe51d8341a0d0a938eb2
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:03:58 2019 -0300

     Fix all the StyleCop warnings in German Parsers (#1358)

    Files:
        -AgeParserConfiguration.cs
        -AreaParserConfiguration.cs
        -CurrencyParserConfiguration.cs
        -DimensionParserConfiguration.cs
        -ItalianNumberWithUnitParserConfiguration.cs
        -LengthParserConfiguration.cs
        -SpeedParserConfiguration.cs
        -TemperatureParserConfiguration.cs
        -VolumeParserConfiguration.cs
        -WeightParserConfiguration.cs
    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

commit 4e8c56765be27d28d75dc7f6837f74da28f1a832
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:02:33 2019 -0300

    Fix all the StyleCop warnings in Italian Extractors (#1357)

    Files:
        -AgeExtractorConfiguration.cs
        -AreaExtractorConfiguration.cs
        -CurrencyExtractorConfiguration.cs
        -DimensionExtractorConfiguration.cs
        -ItalianNumberWithUnitExtractorConfiguration.cs
        -LengthExtractorConfiguration.cs
        -SpeedExtractorConfiguration.cs
        -TemperatureExtractorConfiguration.cs
        -VolumeExtractorConfiguration.cs
        -WeightExtractorConfiguration.cs
    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

commit c59c7b63b3fe73e047b345616320cad6d4046509
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 23:01:23 2019 -0300

    Fix all the StyleCop warnings in Japanese Extractors (#1356)

    Files:
        -AgeExtractorConfiguration.cs
        -CurrencyExtractorConfiguration.cs
        -JapaneseNumberWithUnitExtractorConfiguration.cs

    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line
        -SA1210: Using directives should be ordered alphabetically by the namespaces - Reorder directives

commit 8a7e424894602d8ae598bc1dfb3eb04fe022e2d7
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 22:59:59 2019 -0300

    [StyleCop] Fix all the warnings in NumberWithUnit Models (#1355)

    * Rebasing with master

    * Fix all the StyleCop warnings in Models
    Files:
        -AgeModel.cs
        -CurrencyModel.cs
        -DimensionModel.cs
    Warnings:
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line
        -SA1028: Code should not contain trailing whitespace - Remove trailing whitespace

    * Apply feedback from PR
    - Rename resultbAdd to shouldAdd
    - Rebase from master

commit 43310fc5d4f873b4cb405b618621051a65aec4e9
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sun Jan 20 22:58:50 2019 -0300

    Fix all StyleCop warnings in BooleanExtractorConfiguration files. (#1354)

    - Fixed spacing.
    - Added trailing commas when needed.
    - Added access modifier to classes.

commit c2cae7f945ae03c73d9eb222384899bd4ac2ef66
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Fri Jan 18 14:48:27 2019 +0800

    Fixing Java build break (#1351)

    - Re-disabling "Hoy estaré fuera de cinco a siete" in DateTimePeriod parser for Java
    - Disabling test in dotnet as well as behaviour seems incorrect

commit 54152fc358e53f6fce1eae29473a19228b6f07ca
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Jan 18 02:34:33 2019 -0300

    [.NET] Refactor TimePeriodParser and TimeParser classes (#1350)

    * Refactor of TimePeriodParser and TimePeriodParser classes

    - Extracted of helper classes to Utilities folder.

    * - Removed static qualifiers from TimeFunctions class.

    - Added parameter to Handle method of TimePeriodFunctions class

    * Fix all StyleCop's warnings in TimeParser and TimePeriodParser files.

    - Fixed spacing and trailing commas.
    - Reordered properties, methods and using statements.
    - Added comments to enums.
    - Renamed variables to avoid Hungarian notation.

    * Merge similar TimeFunctions and variable renaming

commit 2e9638172e99ef29c8400c0d3a8cfe86d0343d97
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Jan 18 02:29:55 2019 -0300

    Fix all StyleCop warnings in BooleanExtractorConfiguration files. (#1349)

    - Fixed spacing.
    - Added trailing commas when needed.
    - Added access modifier to classes.

commit fed1ee52e49a209f673c67b22ee79b33e0059c83
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Jan 18 02:27:45 2019 -0300

    Fix all StyleCop warnings in Time, TimeRange and TimexConstraintsHelper files. (#1347)

    - Fixed spacing.
    - Added parenthesis indicating precedence.
    - Added trailing commas when needed.
    - Reordered properties and methods.

commit deac261abefeb23b62843611c0170586a6eae681
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Jan 18 02:27:08 2019 -0300

    [StyleCop] Fix warnings in BotBuilderRecognizerSamples (#1346)

    * Fix StyleCop warnings in BotBuilderSample project
    -MessagesController
    -AssemblyInfo
    -WebApiApplication
    -DeliveryPrompt
    -QuantityPrompt
    -RootDialo

    -Add trailing coma in multi-line initializers
    -Rename file Global to WebApiApplication
    -Remove trailing whitespace

    * Add the ignore of the XML warning

    * Fix Stylecop warnings in SimpleConsole project
    -XML comment analysis warning
    -Update ParseAll method to return a list of model result

    * Fix typo in GetCurrentCultureCode method comment

commit 4275b921641539cef47a4bb0a1ef6b747848ba66
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Fri Jan 18 02:25:20 2019 -0300

    [DateTime] Fix DateTimePeriodExtractor test (#1345)

    * Fix BaseDateTimePeriodExtractor

    * Fix BaseDurationExtractor

    * Fix BaseTimePeriodExtractor

    * Fix "Hoy estaré fuera de cinco a siete" test

    * Revert changes from PR#1003 to fix DateTimePeriodExtractor test
    This closes issue #1342

commit e5862cf35aa240924782da478c261b9728a7522b
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Fri Jan 18 02:23:41 2019 -0300

    [Java][Datetime] Fix Base Extractors (#1344)

    * Fix BaseDateExtractor

    * Fix BaseDatePeriodExtractor

    * Fix BaseDateTimeExtractor

    * Fix BaseDateTimePeriodExtractor

    * Fix BaseDurationExtractor

    * Fix BaseTimePeriodExtractor

commit 8fec11875a2ebc1dffd58ccffea8adcbeccff434
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Fri Jan 18 02:23:10 2019 -0300

     [Java][Datetime] Fix English Extractors and Parsers (#1343)

    * Fix EnglishDateperiodExtractorConfiguration

    * Fix EnglishDateTimePeriodExtractorConfiguration

    * Fix EnglishTimeParserConfiguration

    * Fix TimeParser

commit 2f8ac2ae48a183a0c2b17d9fd87f2e3415bd77f9
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Jan 18 02:22:02 2019 -0300

    [Java][Datetime] Fix ModelComplexCalendar tests (#1340)

    * Enable "Cortana, find time for us to meet between 7 and 9 PM EST ." test

    * Fix timezone resolution

commit c2c48f0f22f6f69c5d340c4a80aa7b5b24e59f2c
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Thu Jan 17 15:46:10 2019 +0800

    Fix wrongly modified language in SampleConsole code (#1341)

commit b528842f699a5fd25cda092982272ac114804376
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:31:46 2019 -0300

    Fix StyleCop warnings in (#1339)

    -ChoiceExtractor
    -BooleanExtractor
    -ChoiceExtractDataResult

    -Add trailing coma
    -Extract ChoiceExtractDataResult class

commit 269bfc8004e13377aa9578040f7262f3a58e3731
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:31:25 2019 -0300

    Fix StyleCop warnings in Choice\Models (#1338)

    -Remove trailing whitespace
    -Fix spacing
    -Add trailing coma in multi-line initializers

commit 11619b5d55e8e8518be7e4ce67f09817cad0cd0e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:30:59 2019 -0300

    Fix StyleCop warnings in Choise\Parsers (#1337)

    -Remove extra black space
    -Add trailing coma in multi-line initializers
    -Separate the file ChoiseParser on to
      --OptionsOtherMatchParseResult
      --OptionsParser
      --OptionsParseDataResult

commit bd763526e7ea99bfc26c05e4c043a8e81356d313
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:30:22 2019 -0300

    Fix StyleCop warning in TimexExpression\English (#1336)

    -TimexConstantsEnglish
    -TimeConvertEnglish
    -TimeRelativeConvertEnglish

commit fd4d487cb2072c0e387aa571b78c71f210d193ba
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:29:54 2019 -0300

    [StyleCop] Fix all warnings in TimexProperty (#1335)

    * Fix all the StyleCop warnings in TimexResolver
    - Remove trailing whitespace
    - Reorder methods and parameters
    - Add trailing comma
    - Create the file for the class Resolution

    * Fix all the StyleCop warnings in TimexProperty
    - Remove trailing whitespace
    - Reorder methods and parameters

    * Fix all the StyleCop warnings in TimexRangeResolver and TimexRegex
    - Add trailing comma
    - Remove trailing whitespace
    - Reorder methods and parameters
    - Remove space before closing brace
    - Style one line functions

commit 1dcd6e4c320ee26a101445659d31c33d92f87dd6
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:28:54 2019 -0300

    Fix StyleCop warnings in (#1334)

    -AssemblyInfo
    -TimexCreator
    -TimexDateHelpers
    -TimexFormat

commit 2d2135cd2ebe005f3ee292078c4fc1f11127171c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Jan 17 00:28:26 2019 -0300

    Fix all StyleCop warnings in TimexHelpers, TimexInference and TimeParsing files. (#1333)

    - Fixed spacing.
    - Added trailing commas when needed.

commit e4b32ccb1eab4920942a0c768dd677532b92e410
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Thu Jan 17 00:28:03 2019 -0300

    [Java][CI] Merge Build.cmd with Build.CI.cmd (#1332)

    * Merge Java build.cmd and build.ci.cmd

    * Delete build.ci.cmd and fix appveyor to target build.cmd

commit edb7be852fe8e7be44cb7c324fafff3d311d28cc
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Thu Jan 17 00:27:01 2019 -0300

    [DotNet][CI] Merge Build.cmd with Build.CI.cmd (#1331)

    * Merge .Net Build.cmd with Build.CI.cmd

    * Remove .Net Build.CI.cmd and retarget AppVeyor to use Build.cmd

commit 7bab159643e179b85555bb87fd6cf8726917af94
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Thu Jan 17 00:25:54 2019 -0300

    [Java][Datetime] Fix tests in DateTimePeriodExtractor (#1328)

    * Fix "Ocurrirá el 1.1.2015 entre 10 y 11:30" test

    * Fix "Hola Cortana- programa una reunión con Jennifer. Necesito una reunión de 30 minutos este viernes por la tarde" test

commit 8ac9a7aa08acd858cfc91c4e7c4f39ea85dd1c28
Author: JuanAr <juan.arguello@southworks.com>
Date:   Wed Jan 16 00:16:40 2019 -0300

    Fix StyleCop warnings in NumberWithUnitExtractor (#1325)

    - Add trailing coma in multi-line initializers
    - Remove trailing whitespace
    - Remove extra blank line�- Extract DinoComparer class
    - Extract PrefixUnitResult class

commit 8a5050fd62085d1db4bbc422f73bee247477ed5c
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Wed Jan 16 00:07:42 2019 -0300

    Activate DateTimeModel tests for Spanish (#1321)

commit 0f8347565d3794888efecee935eec803cc9353d1
Author: Tomas Guzman <42191764+ParadoxARG@users.noreply.github.com>
Date:   Tue Jan 15 23:55:58 2019 -0300

    [Java][Datetime] Update regexes and enable tests (#1319)

    * Update Regexes and enable tests

    * Remove duplicate test

    * Update Regexes with .yaml

    * Enable tests fixed by new regexes

    * Disable tests that failed

    * Change java tests from NotSupportedByDesign to NotSupported

commit 1ba432618fdabb742e05565e91fc6fdb9faa875d
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:49:49 2019 -0300

    [StyleCop] Fix warnings in DataDrivenTest\TestHelpers, Models, Base and StringMatcher files (#1327)

    * Fix StyleCop warning in DataDrivenTest\Matcher
    -StringMatcherTest

    * Fix all the StyleCop warnings in TestBase, TestHelpers and TestModel

commit efbd5e28b31abbbaf38fe2d95665c5b56c88e5d2
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:49:01 2019 -0300

    Fix StyleCop warnings in English Unit Parsers (#1326)

    - WeightParserConfiguration
    - VolumeParserConfiguration
    - TemperatureParserConfiguration
    - SpeedParserConfiguration
    - EnglishNumberWithUnitParserConfiguration
    - LengthParserConfiguration
    - DimensionParserConfiguration
    - CurrencyParserConfiguration
    - AreaParserConfiguration
    - AgeParserConfiguration

commit 337c751730b9202678101ea1abc1eafc1bcf1d01
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:36:05 2019 -0300

    [StyleCop] Fix warnings TextNumberChinese Extractors and Parsers (#1324)

    * Fix all the StyleCop warnings in CardinalExtractor
    -Moved constructor before properties

    * Fix all the StyleCop warnings in DoubleExtractor
    -Move constructor before properties
    -Add trailing comma in the constructor
    -Add spaces before single lined comments

    * Fix all the StyleCop warnings in FractionExtractor
    -Move constructor before properties
    -Add trailing comma
    -Add spaces before comments

    * Fix all the StyleCop warnings in IntegerExtractor
    -Move constructor before properties
    -Add spaces before comments
    -Add trailing comma

    * Fix all the StyleCop warnings in NumberExtractor
    -Move constructor before properties
    -Add description to enum and moved before the class
    -Move protected propertie after internal propertie

    * Fix all the StyleCop warnings in NumberRangeExtractor
    -Move constructor before properties
    -Add trailing comma

    * Fix all the StyleCop warnings in OrdinalExtractor
    -Move constructor before properties
    -Add trailing comma

    * Fix all the StyleCop warnings in PercentageExtractor
    -Move constructor before properties
    -Add trailing comma
    -Remove trailing whitespace

    * Fix StyleCop warnings in ChineseNumberParserConfiguration

    * Fix all the StyleCop warnings in ChineseNumberRangeParserConfiguration
    -Move constructor before properties
    -Add newline for initializers

commit 7be6a6c8c465d1d36a97559e043253fe4e76a26a
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:35:16 2019 -0300

     Fix all the StyleCop warnings in French Unit Parsers (#1323)

    Files:
        -AgeParserConfiguration.cs
        -AreaParserConfiguration.cs
        -CurrencyParserConfiguration.cs
        -DimensionParserConfiguration.cs
        -FrenchNumberWithUnitParserConfiguration.cs
        -LengthParserConfiguration.cs
        -SpeedParserConfiguration.cs
        -TemperatureParserConfiguration.cs
        -VolumeParserConfiguration.cs
        -WeightParserConfiguration.cs
    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

commit 52c9d012355261807264e57def61a4829216e494
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:34:33 2019 -0300

    [StyleCop] Fix all the warnings in Number/Spanish Extractor and Parser files (#1322)

    * Fix StyleCop warnings in SpanishNumberParserConfiguration file

    * Fix StyleCop warnings in Spanish\NumberExtractor file

    * Fix StyleCop warnings in Spanish\IntegerExtractor file

    * Fix StyleCop warnings in Spanish\FractionExtractor file

    * Fix StyleCop warnings in Spanish\DoubleExtractor file

    * Fix StyleCop warnings in Spanish\CardinalExtractor file

    * Fix stylecop warnings incoming from master

    * Apply feedback from PR
    - Add a missing line

commit 4ff6063e7ccad8463490c3142198175e8925f3ad
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:33:40 2019 -0300

    [StyleCop] Fix all warnings in Japanese/MergedDateTimeExtractor file (#1320)

    * Fix Stylecop warning rename file to JapaneseMergedExtractor

    * Fix StyleCop warnings in JapaneseMergedExtractor

    -Reorder using statement
    -Remove extra blank line
    -Fix variable name with Hungarian notation

commit 3a684b3e84b88152ba52ea901500342fe527cb5f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:32:59 2019 -0300

    [StyleCop] Fix all the warnings in Portuguese extractors and parsers (#1318)

    * Fix all StyleCop warnings in PortugueseTimePeriodParserConfiguration

    - Reordered constructor
    - Replaced double quotes to string.Empty

    * Fix all StyleCop warnings in PortugueseMergedParserConfiguration

    - Reordered constructor

    * Fix all StyleCop warnings in PortugueseDateTimePeriodParserConfiguration

    - Reordered constructor
    - Added spaces when needed

    * Fix all StyleCop warnings in PortugueseDateTimeParserConfiguration

    - Reordered constructor
    - Added newline in closing braces

    * Fix all StyleCop warnings in PortugueseMergedExtractorConfiguration

    - Reordered using statements
    - Reordered constructor
    - Added spaces when needed
    - Deleted unnecesary spaces

    * Fix all StyleCop warnings in PortugueseDateTimeAltExtractorConfiguration

    - Reordered using statements
    - Reordered constructor
    - Added internal keyword

    * Changing class from internal to public

commit 7ed47ece90f1b35124a1a8ebabc21c66f71861e0
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:32:10 2019 -0300

    [StyleCop] Fix all the warnings in English Parsers  (#1312)

    * Fix all the StyleCop warnings in Italian Extractors
    Files:
        -AgeExtractorConfiguration.cs
        -AreaExtractorConfiguration.cs
        -CurrencyExtractorConfiguration.cs
        -DimensionExtractorConfiguration.cs
        -ItalianNumberWithUnitExtractorConfiguration.cs
        -LengthExtractorConfiguration.cs
        -SpeedExtractorConfiguration.cs
        -TemperatureExtractorConfiguration.cs
        -VolumeExtractorConfiguration.cs
        -WeightExtractorConfiguration.cs
    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

    * Fix all the StyleCop warnings in Italian Parsers
    Files:
      -WeightParserConfiguration
      -VolumeParserConfiguration
      -TemperatureParserConfiguration
      -SpeedParserConfiguration
      -ItalianNumberWithUnitParserConfiguration
      -LengthParserConfiguration
      -DimensionParserConfiguration
      -CurrencyParserConfiguration
      -AreaParserConfiguration
      -AgeParserConfiguration

    Warnings:
        -SA1502: Element should not be on a single line - Move curly braces to different lines
        -SA1201: A field should not follow a property - Reorder fields and properties
        -SA1128: Put constructor initializers on their own line - Move constructor initializer to a different line

    In file CurrencyParserConfiguration:
        -SA1649: File name should match first type name - Rename file

commit b505a8cc2c184c45c999556916aa0763ad756df9
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 23:31:47 2019 -0300

    [StyleCop] Fix warnings TextNumber Bases files (#1286)

    * Fix StyleCop warnings in BaseNumberExtractor
    - Extract LongFormatType class
    - Extract type enum to NumberMode file
    - Remove unnecessary using
    - Remove extra space
    - Update fields to be properties

    * Fix StyleCop warnings in BaseNumberRangeExtractor
    - Extract NumberRangeContants
    - Suppress stylecop warning in constants variable names

    * Move files from Extractors folder to project root

commit a3afcb457ba21e23b3fc895f6b26b33959459a99
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 06:15:05 2019 -0300

    [StyleCop] Fix all warnings in FrenchTimeZoneExtractorConfiguration (#1313)

    * Fix all StyleCop warnings in FrenchTimeZoneExtractorConfiguration

    - Added internal keyword
    - Added spaces when needed

    * Changed class access modifier from internal to public.

commit 29f769d1512c3a539a153dfa8570d9e8b8b6711d
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 06:14:36 2019 -0300

    [StyleCop] Fix warnings TextNumberDutch Extractors and Parsers (#1311)

    * Fix all StyleCop warnings in Dutch\CardinalExtractor and Dutch\DoubleExtractor

    - Reordered properties and methods.
    - Added spaces and trailing commas when needed.

    * Fix all StyleCop warnings in Dutch\FractionExtractor and Dutch\IntegerExtractor

    - Reordered properties and methods.
    - Added spaces and trailing commas when needed.

    * Fix all StyleCop warnings in Dutch\NumberExtractor and Dutch\NumberRangeExtractor

    - Reordered properties and constructors.
    - Added spaces and trailing commas when needed.
    - Placed all regex parameters in one line.

    * Fix all StyleCop warnings in Dutch\OrdinalExtractor and Dutch\PercentageExtractor

    - Reordered properties and constructors.
    - Added spaces and trailing commas when needed.

    * Fix all StyleCop warnings in DutchNumberParserConfiguration and DutchNumberRangeParserConfiguration.

    - Reordered using statements., constructors and properties.
    - Fixed spacing.

commit e875b97b60ec07317cb8b90918b9a88f4db9715e
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Tue Jan 15 17:12:04 2019 +0800

    Fix build break after extraction of CurrencyUnitValue in .NET (#1317)

    * Fix build break after extraction of CurrencyUnitValue in .NET

    * Fixing cast.

commit ee143160bef8328c5886d636242ee2dc73bc79dd
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 03:32:33 2019 -0300

    [StyleCop] Fix all the warnings in TextMatchers - Reorder properties, fields and methods - Remove trailing whitespace - Add trailing comma - Reformat setters and getters (#1309)

commit 5664b8af84996a0e38d3bf4c7dfcc390b4177b8a
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 03:25:30 2019 -0300

    [StyleCop] Fix all the warnings in NumberWithUnit Parsers (#1308)

    * Fix all the StyleCop warnings in BaseCurrencyParser

    Warnings:
    - SA1400: Class should declare an access modifier
    - SA1401: Field should be private
    - SA1122: Use string.Empty for empty strings
    - SA1028: Code should not contain trailing whitespace
    - SA1413: Use trailing comma in multi-line initializers
    - Reorder fields, properties and constructor.
    - Add spaces before comments

    * Fix all the StyleCop warnings in CurrencyUnitValue

    * Fix all the StyleCop warnings in Parsers
    Files:
        -BaseMergedUnitParser.cs
        -INumberWithUnitParserConfiguration.cs
    Warnings:
        -SA1400	Class should declare an access modifier
        -SA1401	Field should be private
        -SA1122	Use string.Empty for empty strings

    * Fix all the StyleCop warnings in NumberWithUnitParser

    Warnings:
        -SA1401	 Field should be private
        -SA1122	 Use string.Empty for empty strings
        -SA1124	Do not use regions
        -Add file with the class UnitValue

    * Rename Config to config to avoid breaking change

commit 492d9f64908d52c8f896f0f1e566ba9c625a4605
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 03:24:05 2019 -0300

    [StyleCop] Fix all the warnings in constructors (#1307)

    * Fix StyleCop warnings in FrenchDateTimeAltParserConfiguration

    * Fix StyleCop warnings in BaseDateParserConfiguration

    * Fix all StyleCop warnings in EnglishDateParserConfiguration

    * Fix all StyleCop warnings in ItalianDateTimeAltParserConfiguration

commit b8e01b68ea5a6a6f7d6ca557f78d8857a9460129
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 03:23:17 2019 -0300

    [StyleCop] Fix all the warnings in Spanish extractors and parsers (#1306)

    * Fix all StyleCop warnings in DateTimePeriodParser

    - Reordered using statements
    - Added spaces when needed

    * Fix all StyleCop warnings in SpanishMergedExtractorConfiguration

    - Reordered using statements
    - Reordered constructor
    - Deleted unnecessary spaces
    - Added spaces when needed

    * Fix all StyleCop warnings in SpanishDateTimeAltExtractorConfiguration

    - Reordered using statements
    - Reordered constructor and fields

commit 925be8ae2673137e512fdfeebf8584659b7a2447
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 02:26:44 2019 -0300

    [StyleCop] Fix all the warnings in DateTime files (#1305)

    * Fix StyleCop warnings in MatchingUtil

    * Fix StyleCop warnings in DurationParsingUtil

    * Fix StyleCop warnings in ConditionalMatch

    * Fix all StyleCop warnings in DateTimePeriodParser
    - Reordered using statements
    - Added spaces when needed

    * Fix StyleCop warnings in FullDateTimeParser

    * Fix StyleCop warnings in BaseHolidayParserConfiguration

    * Fix StyleCop warnings in BaseHolidayParser

    * Fix StyleCop warnings in BaseDurationParser

    * Revert "Fix all StyleCop warnings in DateTimePeriodParser"

commit 349a0bda3647ea47d5e1b46a3d7a0214ffcd1ce5
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 02:25:33 2019 -0300

    [StyleCop] Fix warnings TextNumberFrench Extractors and Parsers (#1290)

    * Fix all the StyleCop warnings in BasePercentageExtractor
    -Reorder fields, constructors and properties
    -Fix documentation

    * Fix all the StyleCop warnings in CardinalExtractor
    -Reorder fields, constructors and properties

    * Fix all the StyleCop warnings in DoubleExtractor
    -Reorder fields, constructors and properties

    * Fix all the StyleCop warnings in FractionExtractor
    -Reorder fields, constructors and properties

    * Fix all the StyleCop warnings in
    -Reorder fields, constructors and properties
    -Remov extra spaces
    -Add trailing comma

    * Fix all the StyleCop warnings in NumberExtractor
    -Reorder fields, constructors and properties
    -Fixed parameters
    -Removed extra spaces

    * Fix all the StyleCop warnings in PercentageExtractor
    -Reorder fields, constructors and properties
    -Removed extra spaces
    -Add trailing comma

    * Fix all the StyleCop warnings in
    -Fix constructor style
    -Remove trailing whitespace

    * Revert "Fix all the StyleCop warnings in BasePercentageExtractor"

    * Fix StyleCop warnings in French/OrdinalExtractor
    -Add trailing coma
    -Reorder properties and constructor

commit 13181681f498c5cfbe6e0edd21a22ba310fb259e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 02:24:38 2019 -0300

    [Java][Datetime] Port SpanishMergedParserConfiguration from C# to Java (#1275)

    * Port SpanishMergedParserConfiguration to Java

commit cd1fd64c88f4039db6c6574f3d172c402910ac2f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 02:23:47 2019 -0300

    Fix Build.CI.cmd to fail on build errors (#1303)

commit efee55d6151a9dc08a693bd84c6321ee89d00f4f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 01:55:38 2019 -0300

    Fix all StyleCop warnings in file AssemblyInfo (#1304)

    - Fixed spacing.

commit 2560d82aebd738d5c2aecdc1893de58a9ebb0843
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Jan 15 01:52:16 2019 -0300

    Add the ItalianTimeParserConfiguration constructor that was deleted (#1301)

commit 70c2a368e48fb0694f8a185574d6dd6076b29362
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Jan 14 07:23:23 2019 -0300

    [Java][Datetime] Port SpanishDateTimeAltParserConfiguration and SpanishSetParserConfiguration from C# to Java (#1274)

    * Enable SpanishSetParserConfiguration tests

    * Port SpanishDateTimeAltParserConfiguration to Java

    * Port SpanishSetParserConfiguration to java

commit 7f6d3cffdd864e9997d83621af5c8b1c8cc2a290
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Jan 14 03:38:32 2019 -0300

    [StyleCop] Fix all warnings in DateTime (#1280)

    * Fix all StyleCop warnings in BaseTimePeriodExtractor

    * Fix StyleCop warnings in BaseTimePeriodParser

    * Fix StyleCop warnings in BaseDateTimePeriodParser

    * Fix all StyleCop warnings in ItalianTimeParserConfiguration

    * Fix StyleCop warnings in Japanese\DateTimeParser

    * Fix variable access modifier in BaseDateTimePeriodParser

    * Fix variable name from timePmStr to matchPmStr

    * Fix variable name from timeAmStr to matchAmStr

    * Fix all StyleCop warnings in SpanishTimeParserConfiguration

    - Reordered constructor
    - Added space to comments
    - Updated amStr to strAm name
    - Updated pmStr to strPm name
    - Added newline after closing braces

    * Fix all StyleCop w…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellarin tellarin tellarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JuanAr @ParadoxARG @tellarin