Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix crash in goto-def on
* Fix crash in goto-def on `@override` When the base type is not defined, getDefinitionFromOverriddenMember will have its type as errorType, which has no symbol. The error handling previously only handled the case of no baseType at all -- which I'm not sure ever actually happens. * Improve checking 1. getTypeAtLocation never returns undefined, only errorType, so check for that. 2. Return directly after missing baseTypeNode instead of continuing to return later. * Experiment with making goto-def on `override` more consistent * Unify static/instance node->symbol->type path * Make getSymbolAtLocation support class expressions and parenthesized expressions * Revert "Make getSymbolAtLocation support class expressions" This reverts commit 4c1b031. * fix semicolon lint
- Loading branch information
Showing 2 changed files with 22 additions and 4 deletions.