New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "exclude" in tsconfig.json #3043

Closed
mhegazy opened this Issue May 5, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@mhegazy
Contributor

mhegazy commented May 5, 2015

tsconfig.json picks all files in the containing folder by default, this is problematic with "node_modules" that contain .ts/.d.ts that are not relevant to the project. "files" is not useful here because of the lack of support for globs (see #1927).

Proposal:

  • support a new property "exclude" that specifies a list of directories/files to exclude.
  • "exclude" is ignored if "files" is present.
{
    "compilerOptions": {
        "out": "../../built/local/tsc.js",
        "sourceMap": true
    },
    "exclude": [
        "script/helper.ts",
        "node_modules"
    ]
}

Note: This is needed if we want any of gulp/grunt/task runner/ProjectK support in VS .

@mhegazy mhegazy added the Bug label May 5, 2015

@mhegazy mhegazy modified the milestones: TypeScript 1.5.2, TypeScript 1.6 May 5, 2015

@mhegazy mhegazy self-assigned this May 5, 2015

@ahejlsberg ahejlsberg assigned ahejlsberg and unassigned mhegazy May 16, 2015

@ahejlsberg ahejlsberg changed the title from Add support "excludes" in tsconfig.json to Add support for "exclude" in tsconfig.json May 16, 2015

@briandipalma

This comment has been minimized.

Show comment
Hide comment
@briandipalma

briandipalma May 26, 2015

Would glob support be enough not to require this feature? I've also had this issue where node_modules was being built but with glob support I'd be fine.

briandipalma commented May 26, 2015

Would glob support be enough not to require this feature? I've also had this issue where node_modules was being built but with glob support I'd be fine.

@ahejlsberg ahejlsberg added the Fixed label Jun 3, 2015

@ahejlsberg ahejlsberg closed this Jun 3, 2015

ivogabe referenced this issue in ivogabe/gulp-typescript Jun 30, 2015

tanguylebarzic pushed a commit to Dashlane/atom-typescript that referenced this issue Oct 2, 2015

@Microsoft Microsoft locked and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.