-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSDoc property and memberof does not work in salsa #7237
Comments
Will the solution for this also include support for https://jsdoc.app/tags-external.html Or perhaps there is already some other open issue for such or we can create one. Thank you. |
Kind of a workaround, maybe... class Value {
constructor() {
Object.defineProperty( this, 'id', { value: _nextId ++ } );
/** @type {number} id */
this.id;
}
} ... but /**
* @property {number} id
*/
class Value {
constructor() {
Object.defineProperty( this, 'id', { value: _nextId ++ } );
}
} I'm investigating setting up type definitions for a large project (https://threejs.org/) and this issue appears to be a blocker, unfortunately. If this is something for which a PR would be welcome and possible, please let us know! |
Since we cannot register intellisense by set a value directly. salsa should support
@memberof
or@property
tagIt also useful for extension method, set a prototype like this cannot registered in intellisense
Which, I think we don't need automatic intellisense in case like this, but please provide some way we could write JSDoc to register custom member on intellisense
The text was updated successfully, but these errors were encountered: