Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolution of @types packages only works with Node-style resolution #9831

Closed
DanielRosenwasser opened this issue Jul 19, 2016 · 2 comments
Closed

Resolution of @types packages only works with Node-style resolution #9831

DanielRosenwasser opened this issue Jul 19, 2016 · 2 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created @types Relates to working with .d.ts files (declaration/definition files) from DefinitelyTyped
Milestone
TypeScript 2.1

Comments

@DanielRosenwasser
Copy link
Member

While it makes sense conceptually, the ideal experience doesn't work out of the box with AMD. We should discuss whether a behavior change makes sense here.
@mhegazy mhegazy added @types Relates to working with .d.ts files (declaration/definition files) from DefinitelyTyped Bug A bug in TypeScript labels Jul 19, 2016
@mhegazy mhegazy added this to the TypeScript 2.0.1 milestone Jul 19, 2016
@mhegazy mhegazy mentioned this issue Jul 22, 2016
Closed
@aindlq aindlq mentioned this issue Aug 11, 2016
Closed
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.0.1 Aug 16, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Aug 16, 2016

We need to refactor the module resolution code to repeat the resolution process if it failed under moduleResolution==Classic and only look under node_modules\@types.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 29, 2016

Duplicate of #11103

@mhegazy mhegazy closed this as completed Sep 29, 2016
@mhegazy mhegazy added the Duplicate An existing issue was already created label Sep 29, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript Duplicate An existing issue was already created @types Relates to working with .d.ts files (declaration/definition files) from DefinitelyTyped
Projects
None yet
Milestone
TypeScript 2.1
Development

No branches or pull requests
3 participants
@DanielRosenwasser @RyanCavanaugh @mhegazy